Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

try to fix http parsing #5262

Merged
merged 3 commits into from
Oct 23, 2018
Merged

try to fix http parsing #5262

merged 3 commits into from
Oct 23, 2018

Conversation

d-a-v
Copy link
Collaborator

@d-a-v d-a-v commented Oct 19, 2018

for #5261 testing

@ascillato
Copy link
Contributor

This PR works great! Parsing has been solved! Great job! 👍

Thanks.

@ascillato
Copy link
Contributor

With last changes, parsing works fine.

Just missing the Alexa Test.

@ascillato
Copy link
Contributor

with last changes, webserver parsing don't work. sorry

@ascillato ascillato mentioned this pull request Oct 23, 2018
Closed
6 tasks
@d-a-v
Copy link
Collaborator Author

d-a-v commented Oct 23, 2018

Last changes reverted, see #5261 (comment)

@ascillato
Copy link
Contributor

@d-a-v

Testing the actual core with the PR #5262, webserver parsing start to work again.

@d-a-v d-a-v merged commit a063c2b into esp8266:master Oct 23, 2018
@d-a-v d-a-v deleted the alexaHasMessedUpEverything branch October 23, 2018 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ascillato ascillato ascillato approved these changes

@devyte devyte devyte approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@d-a-v @ascillato @devyte