Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow override of macros in core_version.h #5268

Merged
merged 4 commits into from
Nov 29, 2018
Merged

Allow override of macros in core_version.h #5268

merged 4 commits into from
Nov 29, 2018

Conversation

SenH
Copy link
Contributor

@SenH SenH commented Oct 22, 2018

So we can override the build description when compiling dev branches with a command flag like -DARDUINO_ESP8266_GIT_DESC=...

@d-a-v
Copy link
Collaborator

d-a-v commented Oct 22, 2018

This file is overridden during the build process in the build path by platform.txtL75-79
(/tmp/arduino-build.../core/core_version.h for linux, elsewhere for windows and macOS).
So if you need this feature, I think you need to update this file.
Unless I miss something, I don't think your changes have any effect.
Did you actually noticed a change with them ?

If you need to be able to check what core you are using at compile time, you may find some interest in #5269 (coincidence)

@SenH
Copy link
Contributor Author

SenH commented Oct 23, 2018

This doesn't change anything for building via Arduino.app or platform.txt but I'm using a custom makefile.

I can add BUILD_EXTRA_FLAGS=-DARDUINO_ESP8266_GIT_DESC=$(ESP_ARDUINO_VERSION) in my makefile and then ESP.getFullVersion() will output the current Git version used for the build. Without the PR it's impossible to redefine these macros.

@earlephilhower earlephilhower added this to the 2.5.0 milestone Nov 29, 2018
@earlephilhower earlephilhower merged commit 1fb9b4e into esp8266:master Nov 29, 2018
@SenH SenH deleted the override-core-version-macro branch December 10, 2018 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants