-
Notifications
You must be signed in to change notification settings - Fork 13.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
i2s can send now buffers #5349
i2s can send now buffers #5349
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great start! If you can make it generally applicable as noted in the review comments, it'll be very handy and reduce CPU significantly!
The code looks good but to be honest when I use the buffer function I get slightly distorted audio. I used a logic analyzer to sniff the i2c bus but all seems to be fine (the timings and the test data are correct). |
I made a small optimization. As I said the code is correct, the sniffing of the I2C bus looks good and it looks like the distortion is coming from my I2C HW (pcm5100) who is causing it, I can't even get a proper sine wave (Checked with my oscilloscope). Please lets move this to the next step :) |
Looks good, should be very useful. Thanks! |
BTW this was my first pull request ever so thanks for your patience :) Silly question, who what am I supposed to do now? Close the pull request? |
Nope, now it gets merged, assuming no further comments :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only signed => unsigned comments.
Congrats on your first PR! You're done now. This is now available in master branch (aka latest git) and will be released in the next core version. |
wohoo! :D |
This is more efficient than sending samples individually. Actually my https://github.com/aguaviva/ESP8266-phone wont work fast enough without this call I added.