Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check for WEP when setting authmode #5364

Merged
merged 3 commits into from
Nov 22, 2018
Merged

Check for WEP when setting authmode #5364

merged 3 commits into from
Nov 22, 2018

Conversation

dav1901
Copy link
Contributor

@dav1901 dav1901 commented Nov 22, 2018

Fix #5359.

@dav1901 dav1901 mentioned this pull request Nov 22, 2018
Closed
6 tasks
d-a-v
d-a-v reviewed Nov 22, 2018
View reviewed changes
Copy link
Collaborator

@d-a-v d-a-v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this ! (this is my code with last sdk update and I did not test it with WEP)
In the WEP case, we also have AUTH_WEP which seems to have never been used.
Did you try your patch with a WEP AP ?

d-a-v
d-a-v approved these changes Nov 22, 2018
View reviewed changes
Copy link
Collaborator

@d-a-v d-a-v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved per confirmation

@d-a-v d-a-v added this to the 2.5.0 milestone Nov 22, 2018
@devyte devyte merged commit 5d57365 into esp8266:master Nov 22, 2018
@dav1901 dav1901 deleted the issue5359 branch November 22, 2018 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devyte devyte devyte approved these changes

@d-a-v d-a-v d-a-v approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@dav1901 @d-a-v @devyte