Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deprecate axTLS, update examples #5366

Merged
merged 36 commits into from
Nov 30, 2018
Merged

deprecate axTLS, update examples #5366

merged 36 commits into from
Nov 30, 2018

Conversation

d-a-v
Copy link
Collaborator

@d-a-v d-a-v commented Nov 22, 2018 •
edited
Loading

None of these changes have been tested yet,
I give them a visibility here, opened to discussion.

@d-a-v d-a-v added this to the 2.5.0 milestone Nov 22, 2018
@d-a-v
Copy link
Collaborator Author

d-a-v commented Nov 22, 2018

This PR also makes BearSSL the default.

devyte
devyte requested changes Nov 24, 2018
View reviewed changes
Copy link
Collaborator

@devyte devyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks to be in the right direction. Minor comments.

libraries/ESP8266HTTPClient/src/ESP8266HTTPClient.cpp Show resolved Hide resolved
libraries/ESP8266WiFi/examples/NTPClient/NTPClient.ino Outdated Show resolved Hide resolved
libraries/ESP8266WiFi/examples/WiFiTelnetToSerial/WiFiTelnetToSerial.ino Show resolved Hide resolved
@d-a-v
Copy link
Collaborator Author

d-a-v commented Nov 25, 2018

This PR

  • deprecates axTLS
  • moves former axTLS examples to BearSSL
  • adds an axTLS only example
  • replaces all SSID/PSK entries with defines STASSID/STAPSK
    those defines can be overriden in your platform.local.txt that way:
compiler.c.extra_flags=-DSTASSID="mylocalssid" -DSTAPSK="mylocalssidpassword"
compiler.cpp.extra_flags={compiler.c.extra_flags}
  • changes example astyle config: #preprocessordirectives are no more indented
  • adds some scripts in tests/
    • examples_restyle.sh
    • run_CI_locally.sh
  • updates WiFiTelnelToSerial example

@d-a-v d-a-v changed the title (WIP) update examples deprecate axTLS, update examples Nov 25, 2018
@earlephilhower earlephilhower self-requested a review November 26, 2018 21:08
earlephilhower
earlephilhower requested changes Nov 29, 2018
View reviewed changes
Copy link
Collaborator

@earlephilhower earlephilhower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the minor BearSSL::setCACert/::setCertification/::setPrivateKey deprecation notes to be added.

libraries/ESP8266HTTPClient/src/ESP8266HTTPClient.cpp Show resolved Hide resolved
libraries/ESP8266WiFi/examples/NTPClient/NTPClient.ino Outdated Show resolved Hide resolved
libraries/ESP8266WiFi/src/WiFiClientSecureBearSSL.h Outdated Show resolved Hide resolved
libraries/ESP8266WiFi/src/WiFiClientSecureBearSSL.h Outdated Show resolved Hide resolved
tests/common.sh Show resolved Hide resolved
tests/examples_restyle.sh Show resolved Hide resolved
earlephilhower
earlephilhower approved these changes Nov 30, 2018
View reviewed changes
Copy link
Collaborator

@earlephilhower earlephilhower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@devyte
Update NTPClient.ino
5385a93 
const char[] => const char *
@devyte
Update interactive.ino
cc15e6f 
const char[] => const char *
@earlephilhower earlephilhower merged commit 92373a9 into esp8266:master Nov 30, 2018
@objarni objarni mentioned this pull request Jan 28, 2019
Closed
@smartynov smartynov mentioned this pull request Oct 17, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devyte devyte devyte approved these changes

@earlephilhower earlephilhower earlephilhower approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@d-a-v @earlephilhower @devyte