Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass string objects by reference #5378

Merged
merged 1 commit into from
Nov 25, 2018
Merged

Pass string objects by reference #5378

merged 1 commit into from
Nov 25, 2018

Conversation

dav1901
Copy link
Contributor

@dav1901 dav1901 commented Nov 25, 2018

No description provided.

devyte
devyte requested changes Nov 25, 2018
View reviewed changes
Copy link
Collaborator

@devyte devyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! Please add const-ness to the args where it's missing, then I will merge.

@devyte devyte merged commit cd05bae into esp8266:master Nov 25, 2018
@devyte devyte added this to the 2.5.0 milestone Nov 25, 2018
@dav1901 dav1901 deleted the args branch November 25, 2018 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devyte devyte devyte approved these changes

Assignees
No one assigned
Labels
component: core component: libraries component: web staged-for-release type: enhancement
Projects
None yet
Milestone
2.5.0
Development

Successfully merging this pull request may close these issues.
2 participants
@dav1901 @devyte