LaborEtArs's mDNS fixed #5384
Closed
LaborEtArs's mDNS fixed #5384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created a new branch to solve commit conflicts with recent changes to ESP8266mDNSResponder.cpp by d-a-v.
|
@LaborEtArs |
unindent
unindent
Add setInstanceName() forwarder for compat
Closed
This was referenced Dec 5, 2018
devyte
approved these changes
Dec 5, 2018
There was a problem hiding this comment.
There are still a few compat method overloads missing as well as some cleanup and formalization work needed, among other minor details, but overall this is just amazing work. Techniques are a bit old fashioned for modern C++, and yet the code structure and style discipline are so good that it makes it irrelevant.
Congratulations @LaborEtArs ! Approved.
DEBUG_OUTPUT needs to go inside DEBUG_EX_ function otherwise throw error if DEBUG_ESP_MDNS_RESPONDER is not defined
[Fixed] Debug output line
Disable DEBUG_ESP_MDNS_RESPONDER by default
|
closing in favour of #5442 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The two examples work well. I did not make further testing.
(may replace #5370)