Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add doc for ESP8266WebServer #5400

Merged
merged 7 commits into from
Dec 8, 2018
Merged

Add doc for ESP8266WebServer #5400

merged 7 commits into from
Dec 8, 2018

Conversation

dav1901
Copy link
Contributor

@dav1901 dav1901 commented Nov 30, 2018

Basic documentation about ESP8266WebServer library.

devyte
devyte approved these changes Dec 8, 2018
View reviewed changes
Copy link
Collaborator

@devyte devyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Far from complete, but it's a start, and it can be filled out progressively.

earlephilhower
earlephilhower requested changes Dec 8, 2018
View reviewed changes
Copy link
Collaborator

@earlephilhower earlephilhower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Space to TAB and we're good!

libraries/ESP8266WebServer/keywords.txt Outdated Show resolved Hide resolved
earlephilhower
earlephilhower approved these changes Dec 8, 2018
View reviewed changes
Copy link
Collaborator

@earlephilhower earlephilhower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@earlephilhower earlephilhower merged commit 783f817 into esp8266:master Dec 8, 2018
@dav1901 dav1901 deleted the doc branch December 8, 2018 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devyte devyte devyte approved these changes

@earlephilhower earlephilhower earlephilhower approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dav1901 @earlephilhower @devyte