Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split AddrList into object-iterator-container components #5410

Merged
merged 4 commits into from
Dec 3, 2018
Merged

Split AddrList into object-iterator-container components #5410

merged 4 commits into from
Dec 3, 2018

Conversation

devyte
Copy link
Collaborator

@devyte devyte commented Dec 2, 2018 •
edited
Loading

Cleanup of the AddrList implementation

@devyte devyte requested a review from d-a-v December 2, 2018 01:41
d-a-v
d-a-v approved these changes Dec 3, 2018
View reviewed changes
Copy link
Collaborator

@d-a-v d-a-v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

c++ is beautiful :)

d-a-v
d-a-v reviewed Dec 3, 2018
View reviewed changes
cores/esp8266/AddrList.h Outdated Show resolved Hide resolved
@devyte devyte merged commit e5d50a6 into esp8266:master Dec 3, 2018
@devyte devyte deleted the addrList branch December 3, 2018 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d-a-v d-a-v d-a-v approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@devyte @d-a-v