New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix OTA #5454

Merged

devyte merged 1 commit into esp8266:master from d-a-v:otafix

Dec 8, 2018

Collaborator

d-a-v commented Dec 8, 2018 •

edited

Loading

#4283 (comment)

OTA protocol is old, it may not be changed or things would break on the user side
OTA received multiple fixes
You are right about the latest fix, it was too simple and didn't take into account this res=connection.recv(4) which is, apart from swallowing data without using them, useless
OTA code is quite hairy to read, you are not a python dev but I you (<--edit) surely could have proposed a fix

[...] all the recent issues with OTA seems to be caused by the changes @d-a-v made to the espota.py

Well... Yes. I didn't change it for pleasure :) I was fixing some other issue.

[...] but I can understand the logic and I am merely pointing out why so many people are having issues with OTA uploads. Take it or leave it.

I can't imagine finding this bug was easy, so a way to fix it might also have popped out from your research, that was @devyte's question.


          fix OTA

4285e0a

esp8266#4283 (comment)

Collaborator

devyte commented Dec 8, 2018

@d-a-v <--- what he said 😄

devyte merged commit e4c6030 into esp8266:master

d-a-v deleted the otafix branch

December 8, 2018 20:52

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet