Fix negative SPIFFS size for 2M/4M (no SPIFFS) boards #5522
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d-a-v
approved these changes
Dec 19, 2018
|
Can this affect the working of OTA or Usage of EEPROM. Because i noticed that few of my devices stopped working after giving an OTA and on looking into the flash's last 5 sectors(1020 -> 1024). I found there was junk and some parts from the firmware code which should have been limited well before the last 5 sectors. |
6 tasks
10 tasks
|
Will this affect every board size? 1Mb, 2, 3 and 4? I know it breaks 4Mb (No SPIFFS) boards after an OTA update. While waiting for beta-3 is there any combination of flash size + SPIFFS size I can use that work? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed by @arihantdaga in xoseperez/espurna#1436
Same as <=1024 KiB boards, just make start=end