Skip to content

Conversation

mcspr
Copy link
Collaborator

@mcspr mcspr commented Mar 26, 2019

Original issue: platformio/platform-espressif8266#101
Doc: https://docs.platformio.org/en/latest/platforms/espressif8266.html#using-arduino-framework-with-staging-version

Update platformio-build.py:

  • extract version from platform.txt (I see no other definitive source for this info)
  • conditionally run makecorever.py script with the same parameters as IDE does
    (however, I am not exactly sure if VerboseAction is a right way to call it, because dependency on git dir sometimes does not work properly)

Update makecorever.py:

  • fix ambiguous bytes+string error with p.stdout.readlines() data
  • check if __name__ == "__main__", move generation into a function to clearly see git commands
  • replace git --git-dir with just git -C, since we already know that .git dir is there
    (unless I am missing some reason for git-dir setting. if it is required, it should probably be --git-dir=.git --work-tree=. -C ...framework...)

@d-a-v d-a-v requested a review from ivankravets April 15, 2019 20:48
@ivankravets ivankravets merged commit c5efb92 into esp8266:master Apr 23, 2019
@ivankravets
Copy link
Collaborator

Thanks!

@mcspr mcspr deleted the pio/core-version-header branch January 7, 2023 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants