TCP connect and send delay fix #6213
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement early exit as connection established or data already sent. (Previous implementation was exiting only on timeout expired)
d-a-v
reviewed
Jun 20, 2019
With just slight paraphrase
d-a-v
reviewed
Jun 24, 2019
d-a-v
approved these changes
Jun 24, 2019
|
reference for reviewers: d-a-v/W5500lwIP#6 (comment) |
devyte
requested changes
Jul 2, 2019
devyte
approved these changes
Jul 5, 2019
Closed
|
Hi, @emelianov @d-a-v @devyte @earlephilhower This PR makes the pubsubclient library to hung (device unresponsive) for 5 seconds if the MQTT broker is down and it is trying to reconnect. Reverting just this commit makes the STAGE core to be fast again as core 2.5.2 while using MQTT. I have just made the PR #6440 in order to fix this hung issue. Thanks. |
This was referenced Aug 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement early exit as connection established or data already sent.
(In my tests previous implementation was exiting only on timeout expired)