-
Notifications
You must be signed in to change notification settings - Fork 13.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Uri with support for regexUri and globUri #6696
Conversation
Path arguments may not contain the value '/' Updated the example
fix trailing space
BTW it is not tested on a real device, because I don't own an esp8266 |
@Bmooij How did you test it if not on real esp8266 ? |
I tested a similar implement on my esp32 But emulating sounds interesting. I will look into that later. |
@Bmooij there seem to be some warnings (unused params) |
Fixes #2019 |
There is an issue when using the regex lib for esp8266 |
I replaced the I tested it with an esp8266. |
Make the example match the existing examples which allow setting the SSID/PSK in the local platform.txt file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very cool, works well. I did a couple trivial tweaks to the example to match the others instead of bothering you for them, but it all looks good.
Only thing missing is some documentation, but the example does show what I think would be a couple common use cases, so approving. We may want to open up a new bug to update the docs with these new calls, but that shouldn't impede this one.
Add support for regex uri and glob uri.
This pull request is a combination of:
#5214
#5467
There is an issue when importing
<regex>