Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make upload.py compatible with existing FS upload #6788

Merged
merged 3 commits into from
Nov 17, 2019
Merged

Make upload.py compatible with existing FS upload #6788

merged 3 commits into from
Nov 17, 2019

Commits on Nov 16, 2019

  1. Make upload.py compatible with existing FS upload 

    PR esp8266#6765 introduced an incompatibility with the existing Java uploaders
for SPIFFS and LittleFS,  breaking them because of the upload.py
parameter format change to support single stage erase/upload.

Add in patch to silently eat the single --end and to parse the write
address and filename properly as generated by calls from the plugins,
while retaining compatibility with the current IDE changes.
    @earlephilhower
    earlephilhower committed Nov 16, 2019
    Configuration menu
    Copy the full SHA
    0c019c4 View commit details
    Browse the repository at this point in the history

  2. Clean upload.py, make platform use write_flash 

    Make upload.py more concise and pythonic.

Use the "write_flash" argument in platform.txt for uploads instead of
assuming anything that is a file is the bin to upload.
    @earlephilhower
    earlephilhower committed Nov 16, 2019
    Configuration menu
    Copy the full SHA
    c7cb2fc View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into fixfsupload

    @earlephilhower
    earlephilhower authored Nov 16, 2019
    Configuration menu
    Copy the full SHA
    bdf3d67 View commit details
    Browse the repository at this point in the history