Add start, end, progress, and error callbacks for ESP8266HTTPUpdate #6796
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devyte
approved these changes
Nov 17, 2019
|
I'm going to merge this with an update for #2694, too, which has add'l CBs. |
earlephilhower
force-pushed
the
starthttpupdater
branch
from
74662b6 to
851c36e
Compare
earlephilhower
changed the title
|
Now implements the 4 CBs in@karlp's #2694. |
Replaces abandoned esp8266#1817 and esp8266#2694 Add optional std::function callback (so it supports lambdas and normal functions) via ::onStart, ::onEnd, ::onProgress, and ::onError methods. Update example with their use. From @baruch's original pull request: The callback is called when the upgrade actually starts rather than just the initial query so that the user can know that it will not take longer and can also prepare for the upgrade by shutting down other works. From @karlp's original pull request: Incomplete: I've not updated any documentation yet. If this style looks good, I'll happily go and update the documentation (likewise for the examples)
earlephilhower
force-pushed
the
starthttpupdater
branch
from
5c81aa2 to
3eccd37
Compare
|
Fixes #4183 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces abandoned #1817
Add an optional std::function callback (so it supports lambdas and
normal functions) with an optional data parameter (for passing in a
thisor other state info).Update example with its use.
From @baruch's original pull request:
The callback is called when the upgrade actually starts rather than just
the initial query so that the user can know that it will not take longer
and can also prepare for the upgrade by shutting down other works.