Remove user_interface.h from gdbstub includes #6862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid a warning by not including the unneeded "user_interface.h" from gdbstub.c. Leftover from original stub code from the SDK, this include is unnecessary in the Arduino core.
Ensure the same user_interface warning doesn't occur in the future by adding the example shown in the GDB docs to the CI build process.
devyte
approved these changes
Dec 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid a warning by not including the unneeded "user_interface.h" from
gdbstub.c. Leftover from original stub code from the SDK, this include
is unnecessary in the Arduino core.