Reduce temporary string creation in HTTPClient::sendHeader #6937
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dirkmueller
changed the title
dirkmueller
force-pushed
the
http_codeopt
branch
2 times, most recently
from
a4064ae to
cfd0208
Compare
This improves both performance due to fewer memory allocations/copies as well as reduces code size by ~ 25% (150 bytes)
dirkmueller
force-pushed
the
http_codeopt
branch
from
cfd0208 to
0a67c66
Compare
devyte
requested changes
Dec 27, 2019
devyte
approved these changes
Dec 27, 2019
devyte
approved these changes
Dec 28, 2019
earlephilhower
approved these changes
Dec 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves both performance due to fewer memory allocations/copies
as well as reduces code size by ~ 25% (150 bytes)