Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a python3 script to call python3 #6960

Merged
merged 6 commits into from
Jan 14, 2020

Commits on Dec 29, 2019

  1. Use a python3 script to call python3

    It's odd, but because Windows requires a full Python3 install we must
    have an executable called "tools/python3/python3" to use Python3 in the
    toolchain.
    
    Before, we simply symlinked to /usr/bin/python3 (for Linux) or
    /usr/local/bin/python3 (Mac).  Unfortunately, depending on the method of
    installation, on MacOS the Python3 executable can be in /usr/bin/python3
    instead.
    
    To avoid the entire issue, unify the Mac and Linux python3 placeholders
    to use python3 itself to jump to the real executable.
    
    Fixes esp8266#6931
    earlephilhower committed Dec 29, 2019
    Configuration menu
    Copy the full SHA
    a1a0d5f View commit details
    Browse the repository at this point in the history
  2. Explicitly remove old symlink to python3

    The tar extraction for the updated python3 tarball will fail on systems
    that already have a symlink in /tools/python3/python3 because the tar
    extractor attempts to open the *target of the symlink* (i.e. the actual
    interpreter in /usr/bin or /usr/local/bin).
    
    Add a commented hack to destroy this symlink before expanding the
    tarballs, if the file exists.  This is safe to do since it will be
    overwritten by any extractions of the python3 tarball later in the
    process.
    earlephilhower committed Dec 29, 2019
    Configuration menu
    Copy the full SHA
    ecf2f82 View commit details
    Browse the repository at this point in the history

Commits on Jan 1, 2020

  1. Configuration menu
    Copy the full SHA
    11c3458 View commit details
    Browse the repository at this point in the history

Commits on Jan 6, 2020

  1. Configuration menu
    Copy the full SHA
    4ea2886 View commit details
    Browse the repository at this point in the history

Commits on Jan 11, 2020

  1. Configuration menu
    Copy the full SHA
    260d259 View commit details
    Browse the repository at this point in the history

Commits on Jan 14, 2020

  1. Configuration menu
    Copy the full SHA
    5eeaa80 View commit details
    Browse the repository at this point in the history