Skip to content

Conversation

d-a-v
Copy link
Collaborator

@d-a-v d-a-v commented Feb 24, 2020

fixes #7107
@Jason2866 do you confirm tasmota fits in its previous size ?
About that, are you using compressed OTA ?

Copy link
Collaborator

@earlephilhower earlephilhower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great way to save code for those left with 512KB flash!, while preserving the use of library code.

Other than the #if comment from @devyte, LGTM.

@Jason2866
Copy link
Contributor

Jason2866 commented Feb 25, 2020

@d-a-v Thx!, The PR eliminates the firmware size increase. :-)
Yes, we do use compressed and uncompressed OTA. Both works like a charm!

@d-a-v
Copy link
Collaborator Author

d-a-v commented Feb 25, 2020

I was asking about OTA because I have been thinking that increased size on one side would be compensated by size decrease on the other (thanks to compressed OTA). But as @earlephilhower noted, there are still 512K flash chips around, these ones could use any flash size optimization.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Code size increase of 6k in esp-quick-toolchain
4 participants