Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add isRunning getter to check is ::begin already called #7219

Merged
merged 4 commits into from
Apr 17, 2020
Merged

Add isRunning getter to check is ::begin already called #7219

merged 4 commits into from
Apr 17, 2020

Conversation

BbIKTOP
Copy link
Contributor

@BbIKTOP BbIKTOP commented Apr 17, 2020

Fixes #7214

@earlephilhower
Copy link
Collaborator

@BbIKTOP you have an astyle error. You can fix them by running tests/restyle-examples-only.sh or manually by just adding the missing space in this case.

@BbIKTOP
Copy link
Contributor Author

BbIKTOP commented Apr 17, 2020

Yes, it's a new computer, just found that astyle was not installed. Fixed.

@devyte devyte merged commit a36a6c8 into esp8266:master Apr 17, 2020
@devyte devyte added this to the 2.7.0 milestone Apr 17, 2020
@BbIKTOP BbIKTOP deleted the mDNS_Status_Getter_isRunning branch April 21, 2020 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devyte devyte devyte approved these changes

@d-a-v d-a-v d-a-v approved these changes

Assignees
No one assigned
Labels
component: libraries level: easy type: enhancement
Projects
None yet
Milestone
2.7.0
Development

Successfully merging this pull request may close these issues.

No way to check, MDNSResponder::begin has been called or not
4 participants
@BbIKTOP @earlephilhower @d-a-v @devyte