Ability to set connect timeout in WifiMulti->run #7420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikaelBertze
changed the title
d-a-v
approved these changes
Jul 1, 2020
Done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WifiMulti->run has a built in timeout when connecting set to 5s. In some cases this is not enough time to set up the connection.
I noticed that my ESP-boards quite often failed to connect to my wifi if my repeater mode AP was selected as the strongest SSID. Don't know the reason for the slow connection setup, but my other devices connect without issue.
For Esp32, the 5s timeout was added some time ago based on this project (https://github.com/espressif/arduino-esp32/pull/1220/files). They implemented it a bit different where the timeout could be altered and with a default set to 5s.
I made a PR that changes the API to the same as for Esp32.