LEA mDNS v2 #7540
Merged
LEA mDNS v2 #7540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Labor-Et-Ars
commented
Aug 20, 2020
•
Labor-Et-Ars
commented
- based on real @LaborEtArs's work on LEAmDNSv2
- Interface agnostic: a single instance for all interfaces
- compatible with IPv6
- experimental, WIP
- not enabled by default (enabled mDNS remains the same)
- adapted/updated by @hreintke and @d-a-v
d-a-v
approved these changes
Sep 22, 2020
devyte
approved these changes
Sep 22, 2020
There was a problem hiding this comment.
Alright, after discussion, I'm approving this as-is due to the size of the PR and complexity of the code, with the understanding that the remaining comments must be addressed in follow up PRs. Some of my comments are of minor impact and open for discussion (e.g.: use of smart ptrs is meant to reduce code fragility), some of my comments are of high impact and eventual must-haves (e.g.: about the define that disables the extern statement for the global MDNS instance).
A general issue should be opened to track the follow up work as a whole, but we can discuss individual comments here for now.
Let's get this one merged!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.