Skip to content

fixed bug in parsing POST file uploads #7543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Nov 2, 2020
Merged

fixed bug in parsing POST file uploads #7543

merged 6 commits into from
Nov 2, 2020

Conversation

mjforan
Copy link
Contributor

@mjforan mjforan commented Aug 23, 2020

This PR fixes #7542. I rewrote the section of the Web Server library which handles files being uploaded via POST requests.

d-a-v
d-a-v reviewed Aug 23, 2020
View reviewed changes
TD-er
TD-er reviewed Aug 30, 2020
View reviewed changes
TD-er
TD-er reviewed Aug 30, 2020
View reviewed changes
@mjforan mjforan requested a review from d-a-v September 17, 2020 20:11
d-a-v
d-a-v approved these changes Sep 20, 2020
View reviewed changes
Copy link
Collaborator

@d-a-v d-a-v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nothing jumps at me after carefully reading.

@earlephilhower earlephilhower self-requested a review October 25, 2020 05:28
earlephilhower
earlephilhower approved these changes Nov 2, 2020
View reviewed changes
Copy link
Collaborator

@earlephilhower earlephilhower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strangely enough I was unable to reproduce your failure with master using the same PEM as you did, but I do see the issue you found in the existing code. Things have to align poorly in the HTTP stream to hit it, I guess.

Thx for the PR!

@earlephilhower earlephilhower merged commit 5d2563e into esp8266:master Nov 2, 2020
@mjforan mjforan deleted the form-post-file-parse branch November 2, 2020 02:51
@luc-github luc-github mentioned this pull request Nov 25, 2020
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@earlephilhower earlephilhower earlephilhower approved these changes

@d-a-v d-a-v d-a-v approved these changes

+1 more reviewer

@TD-er TD-er TD-er left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug in parsing file upload through http form
4 participants
@mjforan @earlephilhower @TD-er @d-a-v