Exception menu: by default new aborts on OOM #7544
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously: new was returning nullptr after calling constructor on null object
earlephilhower
requested changes
Aug 23, 2020
There was a problem hiding this comment.
I think this is only partially there.
The core abi.cpp new/new[] code needs to be modified, too, to set a special "OOM" flag and panic(). The core_postmortem should look at the flag (it already checks a bunch of other things) and dump the appropriate message.
Presently, this will let g++ to call new(), get a nullptr, and try to call the constructor on it...
|
Closing in favor of #7536 which is now simplified, merged with this PR and consider the above review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously: new was returning nullptr after calling constructor on null object
replaces and closes #7536