Avoid #includes with a surrounding namespace #7560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dirkmueller
force-pushed
the
webserver_namespace
branch
from
1fd7d8f
to
ffa074e
Compare
devyte
requested changes
Aug 31, 2020
This is a followup of the discussion in esp8266#6946 (comment) to untangle the namespace/double inclusions in this library.
dirkmueller
force-pushed
the
webserver_namespace
branch
from
0b45cee
to
2e51afe
Compare
6 tasks
d-a-v
approved these changes
Sep 17, 2020
devyte
approved these changes
Sep 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a followup of the discussion in
#6946 (comment)
to untangle the namespace/double inclusions in this library.