Skip to content

Avoid UB and abort on nullptr buffer #7822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 12, 2021
Merged

Avoid UB and abort on nullptr buffer #7822

merged 4 commits into from
Jan 12, 2021

Conversation

paulocsanz
Copy link
Contributor

@paulocsanz paulocsanz commented Jan 12, 2021 •
edited
Loading

Fixes #7821.

This does not report the OOM to the user. But it already prevents UB from Netdump::tcpDumpProcess.

@paulocsanz
Copy link
Contributor Author

paulocsanz commented Jan 12, 2021 •
edited
Loading

I think I've found a better way. Just need to squash the commits before merge.

Is this ok to merge? Or maybe using new ... that throws is better?

earlephilhower
earlephilhower approved these changes Jan 12, 2021
View reviewed changes
Copy link
Collaborator

@earlephilhower earlephilhower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx.

@d-a-v d-a-v merged commit 07241dd into esp8266:master Jan 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@earlephilhower earlephilhower earlephilhower approved these changes

@d-a-v d-a-v d-a-v approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Possible UB on OOM
3 participants
@paulocsanz @earlephilhower @d-a-v