-
Notifications
You must be signed in to change notification settings - Fork 13.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add setSSLVersion call to SSL object #7920
Conversation
Allow users to only allow specific TLS versions for connections with an additional call in their app, similar to the setCiphers call. Fixes esp8266#7918
c1f8290
to
70c8172
Compare
Wow!!! I was working on it (having some trouble installing the Git version in the IDE) and you solved it in a moment, hehe. Thank you very much, it is a very useful feature to not depend on the TLS configuration of the remote server and to be able to specify TLS 1.2 as the only option from the client. |
Can you verify it with your own test and report back? I've done quick things w/curl, but a 2nd-hand report is always useful! |
Umm, apparently it fails! /home/manolodd/Desarrollo/Arduino/NodemcuWifiMQTTTLStls12_5/NodemcuWifiMQTTTLStls12_5.ino: In function 'void setupMQTT()': If I add the following method
to class WiFiClientSecure : public WiFiClient (is missing) then everything compiles, but once flashed to my NodeMCU it throws an exception. My mosquitto is running only TLS 1.2 nmap --script ssl-enum-ciphers -p 8883 localhost PORT STATE SERVICE And without trying to set the TLS version with the new method, my sketch works fine, so It uses TLS 1.2. I need to do some additional tests. |
ctx: cont --------------- CUT HERE FOR EXCEPTION DECODER --------------- ets Jan 8 2013,rst cause:2, boot mode:(3,6) load 0x4010f000, len 3460, room 16 |
My fault!!! I forgot the "_ctx->" in
You only have to add this method to class WiFiClientSecure : public WiFiClient and everything seems to work fine: Conectando 8C:AA:B5:7C:82:B4 a la red WiFi MEREET...¡Conectado! So... simply add this method! Thank you so much. |
An equivalent option for the WiFiServerSecure should also be made available. Pushing past 3.0.0 |
Allow users to only allow specific TLS versions for connections with an
additional call in their app, similar to the setCiphers call.
Fixes #7918