Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MOD-WIFI-ESP8266(-DEV) update #8297

Merged
merged 6 commits into from
Oct 31, 2021
Merged

MOD-WIFI-ESP8266(-DEV) update #8297

merged 6 commits into from
Oct 31, 2021

Conversation

Stanimir-Petev
Copy link
Contributor

Added Flash mode and reset method selection options for Olimex board MOD-WIFI-ESP8266(-DEV)

@Stanimir-Petev
MOD-WIFI-ESP8266(-DEV) update
91031be 
Added Flash mode and reset method selection options for Olimex board MOD-WIFI-ESP8266(-DEV)
earlephilhower
earlephilhower requested changes Sep 1, 2021
View reviewed changes
Copy link
Collaborator

@earlephilhower earlephilhower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't going to pass CI. You need to update tools/boards.txt.py and regenerate the boards.txt file from it,, not manually edit boards.txt.

Plus, it seems like you're doing both normal definitions and menu overridden ones which is not correct. See line 5832-5833 and 5849-5850.

@Stanimir-Petev
Copy link
Contributor Author

Stanimir-Petev commented Sep 3, 2021 •
edited
Loading

@earlephilhower thank you for the advice! I wasn't aware of the python script inside the "/tools" folder.
After you mentioned about the double definitions of the FlashMode I noticed that I did the same mistake with the ResetMethod.
Now as it's done via the boards.txt.py script is there anything else that needs to be done in order to be valid?

The whole point of adding these options are that we have new flash memory chips on the board that works in those modes: ResetMethod: no dtr (aka ck); and FlashMode: QOUT.

earlephilhower
earlephilhower approved these changes Oct 31, 2021
View reviewed changes
Copy link
Collaborator

@earlephilhower earlephilhower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@earlephilhower earlephilhower merged commit 3f5a76c into esp8266:master Oct 31, 2021
hasenradball pushed a commit to hasenradball/Arduino that referenced this pull request Nov 18, 2024
@Stanimir-Petev @hasenradball
MOD-WIFI-ESP8266(-DEV) update (esp8266#8297)
ebc7f10 
Added Flash mode and reset method selection options for Olimex board MOD-WIFI-ESP8266(-DEV)
The addition of the FlashMode and ResetMethod selection options via boards.txt.py generation file.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d-a-v d-a-v d-a-v approved these changes

@earlephilhower earlephilhower earlephilhower approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Stanimir-Petev @earlephilhower @d-a-v