Skip to content

Conversation

mhightower83
Copy link
Contributor

Issue posted to commit
d1d4212#r73517358

Should resolve UnicodeDecodeError: multibyte-byte.
I don't have an environment to test this; however, this version still works on my machine.

The python docs say "UTF-8 is one of the most commonly used encodings, and Python often defaults to using it."
Hmm, "often" wasn't often enough. I set encoding to "utf-8" for all open() calls. Is there a chance that doing all of them will cause a problem?

@mhightower83 mhightower83 marked this pull request as draft May 12, 2022 23:30
@jjsuwa-sys3175
Copy link
Contributor

LGTM

IMHO touching utime should open by encoding-independent manner eg. binary mode

@mhightower83 mhightower83 marked this pull request as ready for review May 13, 2022 16:26
@d-a-v d-a-v merged commit 5311c0d into esp8266:master May 15, 2022
@mhightower83 mhightower83 deleted the pr-build-opt-utf-8 branch May 17, 2022 18:36
hasenradball pushed a commit to hasenradball/Arduino that referenced this pull request Nov 18, 2024
* Fix utf-8 encoding

Issue posted to commit
esp8266@d1d4212#r73517358

* Added python source code encoding

* for touch operations open/create file in binary mode
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants