Arduino 3 / ESP IDF 5 compatibility #11
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes some changes to allow the AsyncTCP lib to be compatible with Arduino 3 / ESP IDF 5 that will be released next.
Sadly, the
IPv6Address
class has been removed...I've tried to keep the API as close as possible, so that users will just have to update from
IPv6Address
toIPAddress
which is now used for both types (and this is also what many other languages also do).I would have preferred that the removal were done in a deprecating and backward compatible way instead of breaking the API like the butchery job they did. I think they should have kept this
IPv6Address
, enhanced theIPAddress
class (and make it a super class) and introduce aIPv4Address
class. The Java language has a pretty good example of abstraction already working since years.In this PR I also updated the CI job to build with both the released version and dev version of espressif / arduino.
Compilation pass in my fork, but the changes in this PR were not tested with IPv6 (only with Pv4 and Arduino 3).