Guard against concurrent access of the queues when using multiple tasks #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
good news, no crash during all night! I will continue testing for longer time. I usually got a crash per hour caused by these concurrent access. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I currently have some random crashes due to the fact that the queues in the WS implementation are accessed from different RTOS tasks. I've placed some locks today, now trying to run it for a while to see if it crashed again in the queue loop. So far, a few hours without crash.
I am pushing 1 or 2 ws events each second and the app can also react based on incoming ws events.
This seems to work but I am not sure if there is a more efficient way to fix that.
I've opened this PR as draft because I'd like to test it for a few days.
Code inspired by: