Add shutdown&safe mode button #1725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
|
Can you please rebase your branch form next to remove the Thanks |
jsuanet
force-pushed
the
shutdown_safe_mode_button
branch
from
b70b689 to
242a7b2
Compare
jsuanet
force-pushed
the
shutdown_safe_mode_button
branch
from
242a7b2 to
864e886
Compare
|
✔️ Deploy Preview for esphome ready! 🔨 Explore the source changes: 864e886 🔍 Inspect the deploy log: https://app.netlify.com/sites/esphome/deploys/61c08138c34ff700072475fb 😎 Browse the preview: https://deploy-preview-1725--esphome.netlify.app |
|
@jesserockz The rebase is done. There were some problems but with the help of @mmakaay they are solved. I see the deploy/netlify check has failed, looking at the log, I think this failure is not related to my changes. Is it possible to restart this test? |
oxan
approved these changes
Dec 20, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Related issue (if applicable): fixes
Pull request in esphome with YAML changes (if applicable): esphome/esphome#
Checklist:
nextis for changes and new documentation that will go public with the next ESPHome release. Fixes, changes and adjustments for the current release should be created againstcurrent./index.rstwhen creating new documents for new components or cookbook.