Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WS2811 to esp32_rmt_led_strip #7353

Merged
merged 2 commits into from
Aug 27, 2024
Merged

Add WS2811 to esp32_rmt_led_strip #7353

merged 2 commits into from
Aug 27, 2024

Conversation

angelnu
Copy link
Contributor

@angelnu angelnu commented Aug 26, 2024

What does this implement/fix?

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other

Related issue or feature (if applicable): NA

Pull request in esphome-docs with documentation (if applicable): esphome/esphome-docs#4193

Test Environment

  • ESP32
  • ESP32 IDF
  • ESP8266
  • RP2040
  • BK72xx
  • RTL87xx

Example entry for config.yaml:

# Example config.yaml
lights:
  - platform: esp32_rmt_led_strip
    rgb_order: RGB
    pin: D23
    num_leds: 100
    # https://www.tme.eu/Document/26d574b43ad9ddaffa4d5bcd140ec145/WS2811.pdf
    bit0_high: 300 ns
    bit0_low: 1090 ns
    bit1_high: 1090 ns
    bit1_low: 320 ns
    reset_low: 300 us

Checklist:

  • The code change is tested and works locally.
  • Tests have been added to verify that the new code works (under tests/ folder).

If user exposed functionality or configuration variables are added/changed:

@codecov-commenter
Copy link

codecov-commenter commented Aug 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.95%. Comparing base (4d8b5ed) to head (e5e1661).
Report is 1214 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #7353      +/-   ##
==========================================
+ Coverage   53.70%   53.95%   +0.24%     
==========================================
  Files          50       50              
  Lines        9408     9668     +260     
  Branches     1654     1707      +53     
==========================================
+ Hits         5053     5216     +163     
- Misses       4056     4128      +72     
- Partials      299      324      +25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@angelnu angelnu marked this pull request as ready for review August 26, 2024 08:38
@angelnu angelnu requested a review from jesserockz as a code owner August 26, 2024 08:38
@probot-esphome
Copy link

Hey there @jesserockz, mind taking a look at this pull request as it has been labeled with an integration (esp32_rmt_led_strip) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@angelnu
Copy link
Contributor Author

angelnu commented Aug 27, 2024

Since the reset support was merged before, I updated this PR to leverage.

Copy link
Member

@jesserockz jesserockz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦 I didnt see this one before commenting yesterday...haha
Nice one

@jesserockz jesserockz merged commit 92ae506 into esphome:dev Aug 27, 2024
24 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants