Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lvgl] Msgbox fixes and enhancements #7380

Merged
merged 7 commits into from
Sep 9, 2024
Merged

Conversation

clydebarrow
Copy link
Contributor

@clydebarrow clydebarrow commented Aug 30, 2024

What does this implement/fix?

  • Apply msgbox styles to the msgbox, not the window shade outer object.
  • Add button_style key for customising buttons in msgboxes
  • Fix build exception with missing close_button key.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other

Related issue or feature (if applicable): fixes

Pull request in esphome-docs with documentation (if applicable): esphome/esphome-docs#4209

Test Environment

  • ESP32
  • ESP32 IDF
  • ESP8266
  • RP2040
  • BK72xx
  • RTL87xx
  • host

Example entry for config.yaml:

# Example config.yaml

Checklist:

  • The code change is tested and works locally.
  • Tests have been added to verify that the new code works (under tests/ folder).

If user exposed functionality or configuration variables are added/changed:

@codecov-commenter
Copy link

codecov-commenter commented Aug 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.93%. Comparing base (4d8b5ed) to head (736f6bc).
Report is 1277 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #7380      +/-   ##
==========================================
+ Coverage   53.70%   53.93%   +0.22%     
==========================================
  Files          50       50              
  Lines        9408     9678     +270     
  Branches     1654     1708      +54     
==========================================
+ Hits         5053     5220     +167     
- Misses       4056     4134      +78     
- Partials      299      324      +25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@clydebarrow clydebarrow changed the title [lvgl] Bugfixes [lvgl] Msgbox fixes and enhancements Aug 31, 2024
If no close button is specified, make a click outside the box close it.
@probot-esphome probot-esphome bot removed the small-pr label Aug 31, 2024
@clydebarrow clydebarrow marked this pull request as ready for review September 9, 2024 01:10
@jesserockz jesserockz merged commit 9722876 into esphome:dev Sep 9, 2024
26 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Sep 11, 2024
@clydebarrow clydebarrow deleted the lvgl-msgbox branch October 13, 2024 09:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants