-
-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Haier climate integration update #7416
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #7416 +/- ##
==========================================
+ Coverage 53.70% 53.97% +0.26%
==========================================
Files 50 50
Lines 9408 9688 +280
Branches 1654 1711 +57
==========================================
+ Hits 5053 5229 +176
- Misses 4056 4128 +72
- Partials 299 331 +32 ☔ View full report in Codecov by Sentry. |
paveldn
force-pushed
the
haier_update
branch
2 times, most recently
from
September 6, 2024 05:50
f96cb10
to
ff4f3ff
Compare
paveldn
force-pushed
the
haier_update
branch
from
September 6, 2024 06:26
ff4f3ff
to
9b3302f
Compare
3 tasks
jesserockz
requested changes
Sep 11, 2024
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
paveldn
force-pushed
the
haier_update
branch
from
September 11, 2024 09:50
6df9992
to
502e3aa
Compare
jesserockz
approved these changes
Sep 13, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix?
New features and fixes added for Haier climate integration:
Types of changes
Related issue or feature (if applicable): fixes
Pull request in esphome-docs with documentation (if applicable): esphome/esphome-docs#4228
Test Environment
Example entry for
config.yaml
:Checklist:
tests/
folder).If user exposed functionality or configuration variables are added/changed: