Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add clean_session as configurable option to the MQTT component #7501

Merged

Conversation

victorclaessen
Copy link
Contributor

@victorclaessen victorclaessen commented Sep 26, 2024

What does this implement/fix?

Add support to configure the clean_session flag for the MQTT connection.
The underlying MQTT library already supported it, it was just not configurable for the user.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other

Related issue or feature (if applicable):

Pull request in esphome-docs with documentation (if applicable):

Test Environment

  • ESP32
  • ESP32 IDF
  • ESP8266
  • RP2040
  • BK72xx
  • RTL87xx

Example entry for config.yaml:

mqtt:
  clean_session: True

Checklist:

  • The code change is tested and works locally.
  • Tests have been added to verify that the new code works (under tests/ folder).

If user exposed functionality or configuration variables are added/changed:

@codecov-commenter
Copy link

codecov-commenter commented Sep 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.98%. Comparing base (4d8b5ed) to head (b22d2aa).
Report is 1367 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #7501      +/-   ##
==========================================
+ Coverage   53.70%   53.98%   +0.27%     
==========================================
  Files          50       50              
  Lines        9408     9688     +280     
  Branches     1654     1711      +57     
==========================================
+ Hits         5053     5230     +177     
- Misses       4056     4127      +71     
- Partials      299      331      +32     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jesserockz jesserockz merged commit 3df25a1 into esphome:dev Sep 26, 2024
30 checks passed
@victorclaessen victorclaessen deleted the mqtt-clean-session-configurable branch September 27, 2024 07:09
@github-actions github-actions bot locked and limited conversation to collaborators Sep 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MQTT persistence? (or am I missing a point?)
3 participants