Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ledc): Allow attaching multiple pins to 1 channel #10032

Merged
merged 10 commits into from
Jul 16, 2024
Merged

feat(ledc): Allow attaching multiple pins to 1 channel #10032

merged 10 commits into from
Jul 16, 2024

Conversation

P-R-O-C-H-Y
Copy link
Member

@P-R-O-C-H-Y P-R-O-C-H-Y commented Jul 15, 2024 •
edited
Loading

Description of Change

This PR adds back the option to attach multiple pins to the same LEDC channel, which was possible in 2.X versions.
Also new function ledcWriteChannel was added.

Tests scenarios

Tested locally on all supported targets.

Related links

Closes #10010

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 15, 2024 •
edited
Loading

Warnings
⚠️ Please consider squashing your 10 commits (simplifying branch history).

👋 Hello P-R-O-C-H-Y, we appreciate your contribution to this project!

Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 4dbde96

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 15, 2024 •
edited
Loading

Test Results

 56 files  ±0   56 suites  ±0   5m 4s ⏱️ +12s
 21 tests ±0   21 ✅ ±0  0 💤 ±0  0 ❌ ±0 
135 runs  ±0  135 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 4dbde96. ± Comparison against base commit e54fb9e.

♻️ This comment has been updated with latest results.

@me-no-dev
Copy link
Member

Please add example

@VojtechBartoska VojtechBartoska added Area: Peripherals API Relates to peripheral's APIs. Status: In Progress Issue is in progress labels Jul 15, 2024
@VojtechBartoska
Copy link
Collaborator

Closes #10010

@P-R-O-C-H-Y P-R-O-C-H-Y force-pushed the feat/ledc-multiple-pins-single-channel branch from be04d7a to 19c6500 Compare July 15, 2024 13:01
@P-R-O-C-H-Y P-R-O-C-H-Y force-pushed the feat/ledc-multiple-pins-single-channel branch from d96ce9f to 20ffddb Compare July 15, 2024 13:36
@P-R-O-C-H-Y P-R-O-C-H-Y force-pushed the feat/ledc-multiple-pins-single-channel branch from 20ffddb to 297f132 Compare July 15, 2024 13:57
@P-R-O-C-H-Y P-R-O-C-H-Y marked this pull request as ready for review July 15, 2024 13:57
@P-R-O-C-H-Y P-R-O-C-H-Y added Status: Review needed Issue or PR is awaiting review and removed Status: In Progress Issue is in progress labels Jul 15, 2024
@lucasssvaz lucasssvaz added Status: Pending Merge Pull Request is ready to be merged and removed Status: Review needed Issue or PR is awaiting review labels Jul 16, 2024
@me-no-dev me-no-dev merged commit 3c1e5a9 into espressif:master Jul 16, 2024
57 of 58 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucasssvaz lucasssvaz lucasssvaz approved these changes

@me-no-dev me-no-dev me-no-dev approved these changes

Assignees
No one assigned
Labels
Area: Peripherals API Relates to peripheral's APIs. Status: Pending Merge Pull Request is ready to be merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ledcWrite() has no option to write a LED-duty to a channel, but only to a specific pin
4 participants
@P-R-O-C-H-Y @me-no-dev @VojtechBartoska @lucasssvaz