Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(libs): Update all libraries to match the core version #10041

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

me-no-dev
Copy link
Member

@me-no-dev me-no-dev commented Jul 16, 2024

From now on core libraries should have the same version as the core

Closes #9947

From now on core libraries will have the same version as the core
Copy link
Contributor

github-actions bot commented Jul 16, 2024

Messages
📖 🎉 Good Job! All checks are passing!

👋 Hello me-no-dev, we appreciate your contribution to this project!


Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 1c411d6

@SuGlider SuGlider self-requested a review July 16, 2024 19:31
@me-no-dev me-no-dev added the Status: Pending Merge Pull Request is ready to be merged label Jul 16, 2024
@me-no-dev me-no-dev merged commit 614c72b into master Jul 16, 2024
42 of 43 checks passed
@me-no-dev me-no-dev deleted the bugfix/libs_versions branch July 16, 2024 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Pending Merge Pull Request is ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DNSServer had some major changes, but the version was not incremented
4 participants