Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added LILYGO T-Watch-S3 & T-Watch-Ultra variants #10175

Merged
merged 4 commits into from
Aug 16, 2024
Merged

Added LILYGO T-Watch-S3 & T-Watch-Ultra variants #10175

merged 4 commits into from
Aug 16, 2024

Conversation

lewisxhe
Copy link
Contributor

Added LILYGO's currently available T-Watch-S3 and the new T-Watch-Ultra variant that will soon be out

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 16, 2024 •
edited
Loading

Warnings
⚠️

Some issues found for the commit messages in this PR:

  • the commit message "Added LILYGO T-Watch-S3 & T-Watch-Ultra variants":
    • summary looks empty
    • type/action looks empty
  • the commit message "Change the maximum upload limit of the rainmaker partition table":
    • summary looks empty
    • type/action looks empty
  • the commit message "Remove extra line breaks":
    • summary looks empty
    • type/action looks empty

Please fix these commit messages - here are some basic tips:

  • follow Conventional Commits style
  • correct format of commit message should be: <type/action>(<scope/component>): <summary>, for example fix(esp32): Fixed startup timeout issue
  • allowed types are: change,ci,docs,feat,fix,refactor,remove,revert,test
  • sufficiently descriptive message summary should be between 20 to 72 characters and start with upper case letter
  • avoid Jira references in commit messages (unavailable/irrelevant for our customers)

TIP: Install pre-commit hooks and run this check when committing (uses the Conventional Precommit Linter).
Messages
📖 You might consider squashing your 4 commits (simplifying branch history).

👋 Hello lewisxhe, we appreciate your contribution to this project!

Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- Addressing info messages (📖) is strongly recommended; they're less critical but valuable.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 57f28e7

@P-R-O-C-H-Y
Copy link
Member

@lewisxhe Can you please add board links in the description?

@lewisxhe
Copy link
Contributor Author

@lewisxhe Can you please add board links in the description?

It is not for sale yet, I am doing preliminary work. Otherwise, after the product is released, you will not be able to find this variant in the Arduino IDE.

P-R-O-C-H-Y
P-R-O-C-H-Y requested changes Aug 16, 2024
View reviewed changes
Copy link
Member

@P-R-O-C-H-Y P-R-O-C-H-Y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lewisxhe PTAL on my comments.

boards.txt Show resolved Hide resolved
boards.txt Outdated Show resolved Hide resolved
boards.txt Outdated Show resolved Hide resolved
variants/lilygo_twatch_s3/pins_arduino.h Outdated Show resolved Hide resolved
P-R-O-C-H-Y
P-R-O-C-H-Y approved these changes Aug 16, 2024
View reviewed changes
Copy link
Member

@P-R-O-C-H-Y P-R-O-C-H-Y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@P-R-O-C-H-Y P-R-O-C-H-Y added the Status: Pending Merge Pull Request is ready to be merged label Aug 16, 2024
@me-no-dev me-no-dev merged commit b8c9b59 into espressif:master Aug 16, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@P-R-O-C-H-Y P-R-O-C-H-Y P-R-O-C-H-Y approved these changes

Assignees
No one assigned
Labels
Status: Pending Merge Pull Request is ready to be merged Type: 3rd party Boards
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lewisxhe @P-R-O-C-H-Y @me-no-dev