Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ci): Log default FQBN if not passed as argument #10302

Merged
merged 1 commit into from
Sep 9, 2024
Merged

fix(ci): Log default FQBN if not passed as argument #10302

merged 1 commit into from
Sep 9, 2024

Conversation

P-R-O-C-H-Y
Copy link
Member

Description of Change

As FQBN is now read in last step of building sketch, there was empty FQBN in the compilation log for sizes report.

Tests scenarios

Related links

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 6, 2024 •
edited
Loading

Messages
📖 🎉 Good Job! All checks are passing!

👋 Hello P-R-O-C-H-Y, we appreciate your contribution to this project!

Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 794b86f

@P-R-O-C-H-Y P-R-O-C-H-Y self-assigned this Sep 6, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 6, 2024 •
edited
Loading

Test Results

 56 files   -  83   56 suites   - 83   5m 4s ⏱️ - 1h 37m 44s
 21 tests  -   9   21 ✅  -   9  0 💤 ±0  0 ❌ ±0 
135 runs   - 168  135 ✅  - 168  0 💤 ±0  0 ❌ ±0 

Results for commit 794b86f. ± Comparison against base commit e70f4d3.

This pull request removes 9 tests. 
performance.coremark.test_coremark ‑ test_coremark
performance.fibonacci.test_fibonacci ‑ test_fibonacci
performance.psramspeed.test_psramspeed ‑ test_psramspeed
performance.ramspeed.test_ramspeed ‑ test_ramspeed
performance.superpi.test_superpi ‑ test_superpi
test_touch_errors
test_touch_interrtupt
test_touch_read
validation.periman.test_periman ‑ test_periman

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 9, 2024

Memory usage test (comparing PR against master branch)

The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.

MemoryFLASH [bytes]FLASH [%]RAM [bytes]RAM [%]
TargetDECINCDECINCDECINCDECINC
ESP32S3💚 -198K‼️ +2104K💚 -17.70‼️ +219.460‼️ +25K0.00‼️ +71.62
ESP32S2000.000.00000.000.00
ESP32C3000.000.00000.000.00
ESP32C6000.000.00000.000.00
ESP32H2000.000.00000.000.00
ESP32000.000.00000.000.00
Click to expand the detailed deltas report [usage change in BYTES]
TargetESP32S3ESP32S2ESP32C3ESP32C6ESP32H2ESP32
ExampleFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAM
ArduinoOTA/examples/BasicOTA00----------
AsyncUDP/examples/AsyncUDPClient00----------
AsyncUDP/examples/AsyncUDPMulticastServer00----------
AsyncUDP/examples/AsyncUDPServer00----------
BLE/examples/BLE5_extended_scan00----------
BLE/examples/BLE5_multi_advertising00----------
BLE/examples/BLE5_periodic_advertising00----------
BLE/examples/BLE5_periodic_sync00----------
BLE/examples/Beacon_Scanner00----------
BLE/examples/Client00----------
BLE/examples/EddystoneTLM_Beacon00----------
BLE/examples/EddystoneURL_Beacon00----------
BLE/examples/Notify00----------
BLE/examples/Scan00----------
BLE/examples/Server💚 -198K‼️ +6K----------
BLE/examples/Server_multiconnect💚 -198K‼️ +6K----------
BLE/examples/UART💚 -198K‼️ +6K----------
BLE/examples/Write00----------
BLE/examples/iBeacon00----------
DNSServer/examples/CaptivePortal‼️ +22K‼️ +4K----------
EEPROM/examples/eeprom_class‼️ +28K‼️ +4K----------
EEPROM/examples/eeprom_extra‼️ +28K‼️ +4K----------
EEPROM/examples/eeprom_write‼️ +28K‼️ +4K----------
ESP32/examples/AnalogOut/LEDCFade‼️ +28K‼️ +4K----------
ESP32/examples/AnalogOut/LEDCSingleChannel‼️ +28K‼️ +4K----------
ESP32/examples/AnalogOut/LEDCSoftwareFade‼️ +28K‼️ +4K----------
ESP32/examples/AnalogOut/SigmaDelta‼️ +28K‼️ +4K----------
ESP32/examples/AnalogOut/ledcFrequency‼️ +28K‼️ +4K----------
ESP32/examples/AnalogOut/ledcWrite_RGB‼️ +28K‼️ +4K----------
ESP32/examples/AnalogRead‼️ +29K‼️ +5K----------
ESP32/examples/AnalogReadContinuous‼️ +28K‼️ +4K----------
ESP32/examples/ArduinoStackSize‼️ +28K‼️ +4K----------
ESP32/examples/CI/CIBoardsTest‼️ +33K‼️ +4K----------
ESP32/examples/Camera/CameraWebServer‼️ +2104K‼️ +19K----------
ESP32/examples/ChipID/GetChipID‼️ +28K‼️ +4K----------
ESP32/examples/DeepSleep/ExternalWakeUp‼️ +29K‼️ +4K----------
ESP32/examples/DeepSleep/TimerWakeUp‼️ +29K‼️ +4K----------
ESP32/examples/DeepSleep/TouchWakeUp‼️ +30K‼️ +4K----------
ESP32/examples/FreeRTOS/BasicMultiThreading‼️ +32K‼️ +5K----------
ESP32/examples/FreeRTOS/Mutex‼️ +28K‼️ +4K----------
ESP32/examples/FreeRTOS/Queue‼️ +28K‼️ +4K----------
ESP32/examples/FreeRTOS/Semaphore00----------
ESP32/examples/GPIO/BlinkRGB‼️ +32K‼️ +4K----------
ESP32/examples/GPIO/FunctionalInterrupt‼️ +28K‼️ +4K----------
ESP32/examples/GPIO/FunctionalInterruptStruct‼️ +28K‼️ +4K----------
ESP32/examples/GPIO/GPIOInterrupt‼️ +28K‼️ +4K----------
ESP32/examples/HWCDC_Events00----------
ESP32/examples/MacAddress/GetMacAddress‼️ +28K‼️ +4K----------
ESP32/examples/RMT/Legacy_RMT_Driver_Compatible‼️ +28K‼️ +4K----------
ESP32/examples/RMT/RMTCallback‼️ +32K‼️ +4K----------
ESP32/examples/RMT/RMTLoopback‼️ +32K‼️ +4K----------
ESP32/examples/RMT/RMTReadXJT‼️ +32K‼️ +4K----------
ESP32/examples/RMT/RMTWrite_RGB_LED‼️ +32K‼️ +4K----------
ESP32/examples/RMT/RMT_CPUFreq_Test‼️ +32K‼️ +4K----------
ESP32/examples/RMT/RMT_EndOfTransmissionState‼️ +32K‼️ +4K----------
ESP32/examples/RMT/RMT_LED_Blink00----------
ESP32/examples/ResetReason/ResetReason‼️ +29K‼️ +4K----------
ESP32/examples/ResetReason/ResetReason2‼️ +28K‼️ +4K----------
ESP32/examples/Serial/BaudRateDetect_Demo‼️ +28K‼️ +4K----------
ESP32/examples/Serial/OnReceiveError_BREAK_Demo‼️ +28K‼️ +4K----------
ESP32/examples/Serial/OnReceive_Demo‼️ +28K‼️ +4K----------
ESP32/examples/Serial/RS485_Echo_Demo‼️ +28K‼️ +4K----------
ESP32/examples/Serial/RxFIFOFull_Demo‼️ +28K‼️ +4K----------
ESP32/examples/Serial/RxTimeout_Demo‼️ +28K‼️ +4K----------
ESP32/examples/Serial/Serial_All_CPU_Freqs‼️ +28K‼️ +4K----------
ESP32/examples/Serial/Serial_STD_Func_OnReceive‼️ +28K‼️ +4K----------
ESP32/examples/Serial/onReceiveExample‼️ +28K‼️ +4K----------
ESP32/examples/TWAI/TWAIreceive‼️ +28K‼️ +4K----------
ESP32/examples/TWAI/TWAItransmit00----------
ESP32/examples/Template/ExampleTemplate00----------
ESP32/examples/Time/SimpleTime‼️ +23K‼️ +4K----------
ESP32/examples/Timer/RepeatTimer‼️ +27K‼️ +4K----------
ESP32/examples/Timer/WatchdogTimer‼️ +27K‼️ +4K----------
ESP32/examples/Touch/TouchButtonV2‼️ +28K‼️ +4K----------
ESP32/examples/Touch/TouchInterrupt‼️ +28K‼️ +4K----------
ESP32/examples/Touch/TouchRead‼️ +28K‼️ +4K----------
ESP32/examples/Utilities/HEXBuilder‼️ +28K‼️ +4K----------
ESP32/examples/Utilities/MD5Builder‼️ +28K‼️ +4K----------
ESP32/examples/Utilities/SHA1Builder‼️ +28K‼️ +4K----------
ESP_I2S/examples/ES8388_loopback‼️ +41K‼️ +4K----------
ESP_I2S/examples/Record_to_WAV00----------
ESP_I2S/examples/Simple_tone‼️ +38K‼️ +4K----------
ESP_NOW/examples/ESP_NOW_Broadcast_Master00----------
ESP_NOW/examples/ESP_NOW_Broadcast_Slave00----------
ESP_NOW/examples/ESP_NOW_Network‼️ +22K‼️ +4K----------
ESP_NOW/examples/ESP_NOW_Serial‼️ +23K‼️ +4K----------
ESP_SR/examples/Basic00----------
ESPmDNS/examples/mDNS-SD_Extended‼️ +22K‼️ +4K----------
ESPmDNS/examples/mDNS_Web_Server‼️ +22K‼️ +4K----------
Ethernet/examples/ETH_W5500_Arduino_SPI‼️ +31K‼️ +4K----------
Ethernet/examples/ETH_W5500_IDF_SPI‼️ +31K‼️ +4K----------
Ethernet/examples/ETH_WIFI_BRIDGE‼️ +27K‼️ +4K----------
FFat/examples/FFat_Test‼️ +28K‼️ +4K----------
FFat/examples/FFat_time‼️ +23K‼️ +4K----------
HTTPClient/examples/Authorization‼️ +21K‼️ +4K----------
HTTPClient/examples/BasicHttpClient‼️ +21K‼️ +4K----------
HTTPClient/examples/BasicHttpsClient00----------
HTTPClient/examples/HTTPClientEnterprise00----------
HTTPClient/examples/ReuseConnection‼️ +21K‼️ +4K----------
HTTPClient/examples/StreamHttpClient‼️ +21K‼️ +4K----------
HTTPUpdate/examples/httpUpdate‼️ +27K‼️ +4K----------
HTTPUpdate/examples/httpUpdateSPIFFS‼️ +28K‼️ +4K----------
HTTPUpdate/examples/httpUpdateSecure‼️ +26K‼️ +4K----------
HTTPUpdateServer/examples/WebUpdater‼️ +25K‼️ +4K----------
Insights/examples/DiagnosticsSmokeTest‼️ +21K‼️ +4K----------
Insights/examples/MinimalDiagnostics‼️ +21K‼️ +4K----------
LittleFS/examples/LITTLEFS_test‼️ +28K‼️ +4K----------
LittleFS/examples/LITTLEFS_time‼️ +23K‼️ +4K----------
NetBIOS/examples/ESP_NBNST‼️ +22K‼️ +4K----------
NetworkClientSecure/examples/WiFiClientInsecure00----------
NetworkClientSecure/examples/WiFiClientPSK00----------
NetworkClientSecure/examples/WiFiClientSecure00----------
NetworkClientSecure/examples/WiFiClientSecureEnterprise‼️ +21K‼️ +4K----------
NetworkClientSecure/examples/WiFiClientSecureProtocolUpgrade‼️ +21K‼️ +4K----------
NetworkClientSecure/examples/WiFiClientShowPeerCredentials‼️ +21K‼️ +4K----------
NetworkClientSecure/examples/WiFiClientTrustOnFirstUse‼️ +20K‼️ +4K----------
PPP/examples/PPP_Basic‼️ +30K‼️ +4K----------
PPP/examples/PPP_WIFI_BRIDGE‼️ +25K‼️ +4K----------
Preferences/examples/Prefs2Struct‼️ +28K‼️ +4K----------
Preferences/examples/StartCounter‼️ +28K‼️ +4K----------
RainMaker/examples/RMakerCustom‼️ +557K‼️ +25K----------
RainMaker/examples/RMakerCustomAirCooler‼️ +556K‼️ +25K----------
RainMaker/examples/RMakerSonoffDualR300----------
RainMaker/examples/RMakerSwitch00----------
SD/examples/SD_Test00----------
SD/examples/SD_time00----------
SD_MMC/examples/SD2USBMSC00----------
SD_MMC/examples/SDMMC_Test00----------
SD_MMC/examples/SDMMC_time00----------
SPI/examples/SPI_Multiple_Buses‼️ +32K‼️ +4K----------
SPIFFS/examples/SPIFFS_Test‼️ +28K‼️ +4K----------
SPIFFS/examples/SPIFFS_time‼️ +23K‼️ +4K----------
SimpleBLE/examples/SimpleBleDevice00----------
TFLiteMicro/examples/hello_world‼️ +30K‼️ +4K----------
Ticker/examples/Blinker‼️ +31K‼️ +4K----------
Ticker/examples/TickerBasic‼️ +31K‼️ +4K----------
Ticker/examples/TickerParameter‼️ +31K‼️ +4K----------
USB/examples/CompositeDevice‼️ +48K‼️ +5K----------
USB/examples/ConsumerControl‼️ +48K‼️ +5K----------
USB/examples/CustomHIDDevice00----------
USB/examples/FirmwareMSC‼️ +51K‼️ +5K----------
USB/examples/Gamepad‼️ +48K‼️ +5K----------
USB/examples/HIDVendor‼️ +48K‼️ +5K----------
USB/examples/Keyboard/KeyboardLogout‼️ +48K‼️ +5K----------
USB/examples/Keyboard/KeyboardMessage‼️ +48K‼️ +5K----------
USB/examples/Keyboard/KeyboardReprogram‼️ +48K‼️ +5K----------
USB/examples/Keyboard/KeyboardSerial‼️ +51K‼️ +5K----------
USB/examples/KeyboardAndMouseControl‼️ +48K‼️ +5K----------
USB/examples/MIDI/MidiController‼️ +48K‼️ +5K----------
USB/examples/MIDI/MidiInterface‼️ +51K‼️ +5K----------
USB/examples/MIDI/MidiMusicBox‼️ +48K‼️ +5K----------
USB/examples/MIDI/ReceiveMidi‼️ +51K‼️ +5K----------
USB/examples/Mouse/ButtonMouseControl00----------
USB/examples/SystemControl00----------
USB/examples/USBMSC‼️ +51K‼️ +5K----------
USB/examples/USBSerial‼️ +51K‼️ +5K----------
USB/examples/USBVendor‼️ +48K‼️ +5K----------
Update/examples/AWS_S3_OTA_Update‼️ +26K‼️ +4K----------
Update/examples/HTTPS_OTA_Update‼️ +21K‼️ +4K----------
Update/examples/HTTP_Client_AES_OTA_Update‼️ +26K‼️ +4K----------
Update/examples/HTTP_Server_AES_OTA_Update‼️ +25K‼️ +4K----------
Update/examples/OTAWebUpdater‼️ +26K‼️ +4K----------
Update/examples/SD_Update‼️ +33K‼️ +4K----------
WebServer/examples/AdvancedWebServer‼️ +25K‼️ +4K----------
WebServer/examples/FSBrowser‼️ +25K‼️ +4K----------
WebServer/examples/Filters💚 -27K‼️ +2K----------
WebServer/examples/HelloServer💚 -27K‼️ +2K----------
WebServer/examples/HttpAdvancedAuth💚 -26K‼️ +2K----------
WebServer/examples/HttpAuthCallback💚 -26K‼️ +2K----------
WebServer/examples/HttpAuthCallbackInline‼️ +25K‼️ +4K----------
WebServer/examples/HttpBasicAuth‼️ +25K‼️ +4K----------
WebServer/examples/HttpBasicAuthSHA1‼️ +25K‼️ +4K----------
WebServer/examples/HttpBasicAuthSHA1orBearerToken‼️ +25K‼️ +4K----------
WebServer/examples/MultiHomedServers‼️ +26K‼️ +4K----------
WebServer/examples/PathArgServer‼️ +23K‼️ +4K----------
WebServer/examples/SDWebServer‼️ +26K‼️ +4K----------
WebServer/examples/SimpleAuthentification‼️ +22K‼️ +4K----------
WebServer/examples/UploadHugeFile‼️ +26K‼️ +4K----------
WebServer/examples/WebServer💚 -23K‼️ +2K----------
WebServer/examples/WebUpdate💚 -26K‼️ +2K----------
WiFi/examples/FTM/FTM_Initiator💚 -27K‼️ +2K----------
WiFi/examples/FTM/FTM_Responder💚 -27K‼️ +2K----------
WiFi/examples/SimpleWiFiServer‼️ +26K‼️ +4K----------
WiFi/examples/WPS‼️ +22K‼️ +4K----------
WiFi/examples/WiFiAccessPoint‼️ +26K‼️ +4K----------
WiFi/examples/WiFiBlueToothSwitch💚 -51K‼️ +7K----------
WiFi/examples/WiFiClient‼️ +22K‼️ +4K----------
WiFi/examples/WiFiClientBasic‼️ +22K‼️ +4K----------
WiFi/examples/WiFiClientConnect‼️ +22K‼️ +4K----------
WiFi/examples/WiFiClientEnterprise‼️ +21K‼️ +4K----------
WiFi/examples/WiFiClientEvents‼️ +22K‼️ +4K----------
WiFi/examples/WiFiClientStaticIP‼️ +22K‼️ +4K----------
WiFi/examples/WiFiExtender💚 -28K‼️ +2K----------
WiFi/examples/WiFiIPv6💚 -29K‼️ +2K----------
WiFi/examples/WiFiMulti💚 -27K‼️ +2K----------
WiFi/examples/WiFiMultiAdvanced00----------
WiFi/examples/WiFiScan‼️ +22K‼️ +4K----------
WiFi/examples/WiFiScanAsync‼️ +22K‼️ +4K----------
WiFi/examples/WiFiScanDualAntenna‼️ +23K‼️ +4K----------
WiFi/examples/WiFiScanTime‼️ +22K‼️ +4K----------
WiFi/examples/WiFiSmartConfig‼️ +23K‼️ +4K----------
WiFi/examples/WiFiTelnetToSerial‼️ +22K‼️ +4K----------
WiFi/examples/WiFiUDPClient‼️ +22K‼️ +4K----------
WiFiProv/examples/WiFiProv‼️ +551K‼️ +25K----------
Wire/examples/WireMaster‼️ +25K‼️ +5K----------
Wire/examples/WireScan‼️ +25K‼️ +5K----------
Wire/examples/WireSlave‼️ +69K‼️ +6K----------
OpenThread/examples/COAP/coap_lamp------------
OpenThread/examples/COAP/coap_switch------------
OpenThread/examples/SimpleCLI------------
OpenThread/examples/SimpleNode------------
OpenThread/examples/SimpleThreadNetwork/LeaderNode------------
OpenThread/examples/SimpleThreadNetwork/RouterNode------------
OpenThread/examples/ThreadScan------------
OpenThread/examples/onReceive------------
BluetoothSerial/examples/DiscoverConnect------------
BluetoothSerial/examples/GetLocalMAC------------
BluetoothSerial/examples/SerialToSerialBT------------
BluetoothSerial/examples/SerialToSerialBTM------------
BluetoothSerial/examples/SerialToSerialBT_Legacy------------
BluetoothSerial/examples/SerialToSerialBT_SSP------------
BluetoothSerial/examples/bt_classic_device_discovery------------
BluetoothSerial/examples/bt_remove_paired_devices------------
ESP32/examples/DeepSleep/SmoothBlink_ULP_Code------------
ESP32/examples/Touch/TouchButton------------
Ethernet/examples/ETH_LAN8720------------
Ethernet/examples/ETH_TLK110------------

@me-no-dev me-no-dev added the Status: Pending Merge Pull Request is ready to be merged label Sep 9, 2024
@me-no-dev me-no-dev merged commit 2853b7c into espressif:master Sep 9, 2024
70 of 71 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@P-R-O-C-H-Y P-R-O-C-H-Y

Labels
Status: Pending Merge Pull Request is ready to be merged Type: CI & Testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@P-R-O-C-H-Y @me-no-dev