Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(psram): Do not abort if PSRAM is not found #10395

Merged
merged 1 commit into from
Oct 1, 2024
Merged

fix(psram): Do not abort if PSRAM is not found #10395

merged 1 commit into from
Oct 1, 2024

Conversation

me-no-dev
Copy link
Member

Also add to heap in app_main

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 1, 2024

Warnings
⚠️ The Pull Request description looks very brief, please check if more details can be added.

👋 Hello me-no-dev, we appreciate your contribution to this project!

Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against ff2c17a

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 1, 2024 •
edited
Loading

Test Results

 41 files   41 suites   3m 12s ⏱️
 19 tests  19 ✅ 0 💤 0 ❌
120 runs  120 ✅ 0 💤 0 ❌

Results for commit ff2c17a.

♻️ This comment has been updated with latest results.

@me-no-dev me-no-dev added the Status: Pending Merge Pull Request is ready to be merged label Oct 1, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 1, 2024

Memory usage test (comparing PR against master branch)

The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.

MemoryFLASH [bytes]FLASH [%]RAM [bytes]RAM [%]
TargetDECINCDECINCDECINCDECINC
ESP32S3000.000.00000.000.00
ESP32S20⚠️ +320.00⚠️ +0.01000.000.00
ESP32C3000.000.00000.000.00
ESP32C6000.000.00000.000.00
ESP32H2000.000.00000.000.00
ESP32💚 -12⚠️ +400.00⚠️ +0.01000.000.00
Click to expand the detailed deltas report [usage change in BYTES]
TargetESP32S3ESP32S2ESP32C3ESP32C6ESP32H2ESP32
ExampleFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAM
ArduinoOTA/examples/BasicOTA00⚠️ +2400000--⚠️ +280
AsyncUDP/examples/AsyncUDPClient00⚠️ +3200000--⚠️ +280
AsyncUDP/examples/AsyncUDPMulticastServer00⚠️ +2400000--⚠️ +280
AsyncUDP/examples/AsyncUDPServer00⚠️ +2400000--⚠️ +280
BLE/examples/BLE5_extended_scan00--000000--
BLE/examples/BLE5_multi_advertising00--000000--
BLE/examples/BLE5_periodic_advertising00--000000--
BLE/examples/BLE5_periodic_sync00--000000--
BLE/examples/Beacon_Scanner00--000000⚠️ +280
BLE/examples/Client00--000000⚠️ +280
BLE/examples/EddystoneTLM_Beacon00--000000⚠️ +280
BLE/examples/EddystoneURL_Beacon00--000000⚠️ +320
BLE/examples/Notify00--000000⚠️ +320
BLE/examples/Scan00--000000⚠️ +280
BLE/examples/Server00--000000⚠️ +280
BLE/examples/Server_multiconnect00--000000⚠️ +200
BLE/examples/UART00--000000⚠️ +280
BLE/examples/Write00--000000⚠️ +320
BLE/examples/iBeacon00--000000⚠️ +280
DNSServer/examples/CaptivePortal00⚠️ +2400000--⚠️ +240
EEPROM/examples/eeprom_class00⚠️ +240000000⚠️ +320
EEPROM/examples/eeprom_extra00⚠️ +240000000⚠️ +320
EEPROM/examples/eeprom_write00⚠️ +240000000⚠️ +320
ESP32/examples/AnalogOut/LEDCFade00⚠️ +240000000⚠️ +320
ESP32/examples/AnalogOut/LEDCSingleChannel00⚠️ +240000000⚠️ +320
ESP32/examples/AnalogOut/LEDCSoftwareFade00⚠️ +240000000⚠️ +320
ESP32/examples/AnalogOut/SigmaDelta00⚠️ +240000000⚠️ +320
ESP32/examples/AnalogOut/ledcFrequency00⚠️ +240000000⚠️ +320
ESP32/examples/AnalogOut/ledcWrite_RGB00⚠️ +240000000⚠️ +320
ESP32/examples/AnalogRead00⚠️ +240000000⚠️ +320
ESP32/examples/AnalogReadContinuous00⚠️ +240000000⚠️ +320
ESP32/examples/ArduinoStackSize00⚠️ +240000000⚠️ +320
ESP32/examples/CI/CIBoardsTest00⚠️ +240000000⚠️ +320
ESP32/examples/Camera/CameraWebServer00⚠️ +280------⚠️ +280
ESP32/examples/ChipID/GetChipID00⚠️ +240000000⚠️ +320
ESP32/examples/DeepSleep/ExternalWakeUp00⚠️ +240------⚠️ +320
ESP32/examples/DeepSleep/TimerWakeUp00⚠️ +2400000--⚠️ +320
ESP32/examples/DeepSleep/TouchWakeUp00⚠️ +240------⚠️ +320
ESP32/examples/FreeRTOS/BasicMultiThreading00⚠️ +240000000⚠️ +320
ESP32/examples/FreeRTOS/Mutex00⚠️ +240000000⚠️ +320
ESP32/examples/FreeRTOS/Queue00⚠️ +240000000⚠️ +320
ESP32/examples/FreeRTOS/Semaphore00⚠️ +240000000⚠️ +320
ESP32/examples/GPIO/BlinkRGB00⚠️ +240000000⚠️ +320
ESP32/examples/GPIO/FunctionalInterrupt00⚠️ +240000000⚠️ +320
ESP32/examples/GPIO/FunctionalInterruptStruct00⚠️ +240000000⚠️ +320
ESP32/examples/GPIO/GPIOInterrupt00⚠️ +240000000⚠️ +320
ESP32/examples/HWCDC_Events00--000000--
ESP32/examples/MacAddress/GetMacAddress00⚠️ +240000000⚠️ +320
ESP32/examples/RMT/Legacy_RMT_Driver_Compatible00⚠️ +240000000⚠️ +320
ESP32/examples/RMT/RMTCallback00⚠️ +240000000⚠️ +320
ESP32/examples/RMT/RMTLoopback00⚠️ +240000000⚠️ +320
ESP32/examples/RMT/RMTReadXJT00⚠️ +240000000⚠️ +320
ESP32/examples/RMT/RMTWrite_RGB_LED00⚠️ +240000000⚠️ +320
ESP32/examples/RMT/RMT_CPUFreq_Test00⚠️ +240000000⚠️ +320
ESP32/examples/RMT/RMT_EndOfTransmissionState00⚠️ +240000000⚠️ +320
ESP32/examples/RMT/RMT_LED_Blink00⚠️ +240000000⚠️ +320
ESP32/examples/ResetReason/ResetReason00⚠️ +240000000⚠️ +320
ESP32/examples/ResetReason/ResetReason200⚠️ +240000000⚠️ +320
ESP32/examples/Serial/BaudRateDetect_Demo00⚠️ +240000000⚠️ +320
ESP32/examples/Serial/OnReceiveError_BREAK_Demo00⚠️ +240000000⚠️ +320
ESP32/examples/Serial/OnReceive_Demo00⚠️ +240000000⚠️ +320
ESP32/examples/Serial/RS485_Echo_Demo00⚠️ +240000000⚠️ +320
ESP32/examples/Serial/RxFIFOFull_Demo00⚠️ +240000000⚠️ +320
ESP32/examples/Serial/RxTimeout_Demo00⚠️ +240000000⚠️ +320
ESP32/examples/Serial/Serial_All_CPU_Freqs00⚠️ +240000000⚠️ +320
ESP32/examples/Serial/Serial_STD_Func_OnReceive00⚠️ +240000000⚠️ +320
ESP32/examples/Serial/onReceiveExample00⚠️ +240000000⚠️ +320
ESP32/examples/TWAI/TWAIreceive00⚠️ +240000000⚠️ +320
ESP32/examples/TWAI/TWAItransmit00⚠️ +240000000⚠️ +320
ESP32/examples/Template/ExampleTemplate00⚠️ +240000000⚠️ +320
ESP32/examples/Time/SimpleTime00⚠️ +3200000--⚠️ +320
ESP32/examples/Timer/RepeatTimer00⚠️ +240000000⚠️ +320
ESP32/examples/Timer/WatchdogTimer00⚠️ +240000000⚠️ +320
ESP32/examples/Touch/TouchButtonV200⚠️ +240--------
ESP32/examples/Touch/TouchInterrupt00⚠️ +240------⚠️ +320
ESP32/examples/Touch/TouchRead00⚠️ +240------⚠️ +320
ESP32/examples/Utilities/HEXBuilder00⚠️ +240000000⚠️ +320
ESP32/examples/Utilities/MD5Builder00⚠️ +240000000⚠️ +320
ESP32/examples/Utilities/SHA1Builder00⚠️ +240000000⚠️ +320
ESP_I2S/examples/ES8388_loopback00⚠️ +240000000⚠️ +320
ESP_I2S/examples/Record_to_WAV00--------⚠️ +320
ESP_I2S/examples/Simple_tone00⚠️ +240000000⚠️ +320
ESP_NOW/examples/ESP_NOW_Broadcast_Master00⚠️ +2800000--⚠️ +320
ESP_NOW/examples/ESP_NOW_Broadcast_Slave00⚠️ +2400000--⚠️ +160
ESP_NOW/examples/ESP_NOW_Network00⚠️ +2400000--⚠️ +320
ESP_NOW/examples/ESP_NOW_Serial00⚠️ +2400000--⚠️ +280
ESP_SR/examples/Basic00----------
ESPmDNS/examples/mDNS-SD_Extended00⚠️ +2800000--⚠️ +280
ESPmDNS/examples/mDNS_Web_Server00⚠️ +2800000--⚠️ +280
Ethernet/examples/ETH_W5500_Arduino_SPI00⚠️ +240000000⚠️ +320
Ethernet/examples/ETH_W5500_IDF_SPI00⚠️ +240000000⚠️ +320
Ethernet/examples/ETH_WIFI_BRIDGE00⚠️ +2800000--⚠️ +280
FFat/examples/FFat_Test00⚠️ +240000000⚠️ +320
FFat/examples/FFat_time00⚠️ +2400000--⚠️ +120
HTTPClient/examples/Authorization00⚠️ +2000000--⚠️ +280
HTTPClient/examples/BasicHttpClient00⚠️ +2000000--⚠️ +280
HTTPClient/examples/BasicHttpsClient00⚠️ +2400000--⚠️ +280
HTTPClient/examples/HTTPClientEnterprise00⚠️ +2400000--⚠️ +280
HTTPClient/examples/ReuseConnection00⚠️ +2400000--⚠️ +280
HTTPClient/examples/StreamHttpClient00⚠️ +2400000--⚠️ +320
HTTPUpdate/examples/httpUpdate00⚠️ +2800000--⚠️ +360
HTTPUpdate/examples/httpUpdateSPIFFS00⚠️ +2400000--⚠️ +320
HTTPUpdate/examples/httpUpdateSecure00⚠️ +2800000--⚠️ +280
HTTPUpdateServer/examples/WebUpdater00⚠️ +2800000--⚠️ +280
Insights/examples/DiagnosticsSmokeTest00⚠️ +2400000--⚠️ +280
Insights/examples/MinimalDiagnostics00⚠️ +2800000--⚠️ +320
LittleFS/examples/LITTLEFS_test00⚠️ +240000000⚠️ +320
LittleFS/examples/LITTLEFS_time00⚠️ +2800000--💚 -120
NetBIOS/examples/ESP_NBNST00⚠️ +2000000--⚠️ +360
NetworkClientSecure/examples/WiFiClientInsecure00⚠️ +2400000--⚠️ +200
NetworkClientSecure/examples/WiFiClientPSK00⚠️ +2400000--⚠️ +280
NetworkClientSecure/examples/WiFiClientSecure00⚠️ +2800000--⚠️ +280
NetworkClientSecure/examples/WiFiClientSecureEnterprise00⚠️ +2800000--⚠️ +280
NetworkClientSecure/examples/WiFiClientSecureProtocolUpgrade00⚠️ +2400000--⚠️ +280
NetworkClientSecure/examples/WiFiClientShowPeerCredentials00⚠️ +1200000--⚠️ +240
NetworkClientSecure/examples/WiFiClientTrustOnFirstUse00⚠️ +2400000--⚠️ +240
PPP/examples/PPP_Basic00⚠️ +240000000⚠️ +320
PPP/examples/PPP_WIFI_BRIDGE00⚠️ +2800000--⚠️ +280
Preferences/examples/Prefs2Struct00⚠️ +240000000⚠️ +320
Preferences/examples/StartCounter00⚠️ +240000000⚠️ +320
RainMaker/examples/RMakerCustom00⚠️ +2400000--⚠️ +280
RainMaker/examples/RMakerCustomAirCooler00⚠️ +2400000--⚠️ +280
RainMaker/examples/RMakerSonoffDualR300⚠️ +2400000--⚠️ +280
RainMaker/examples/RMakerSwitch00000000--⚠️ +280
SD/examples/SD_Test00⚠️ +240000000⚠️ +320
SD/examples/SD_time00⚠️ +2400000--⚠️ +280
SD_MMC/examples/SD2USBMSC00----------
SD_MMC/examples/SDMMC_Test00--------⚠️ +320
SD_MMC/examples/SDMMC_time00--------⚠️ +320
SPI/examples/SPI_Multiple_Buses00⚠️ +240000000⚠️ +320
SPIFFS/examples/SPIFFS_Test00⚠️ +240000000⚠️ +320
SPIFFS/examples/SPIFFS_time00⚠️ +2800000--⚠️ +280
SimpleBLE/examples/SimpleBleDevice00--000000⚠️ +280
TFLiteMicro/examples/hello_world00⚠️ +240000000⚠️ +320
Ticker/examples/Blinker00⚠️ +240000000⚠️ +320
Ticker/examples/TickerBasic00⚠️ +240000000⚠️ +320
Ticker/examples/TickerParameter00⚠️ +240000000⚠️ +320
USB/examples/CompositeDevice00⚠️ +240--------
USB/examples/ConsumerControl00⚠️ +240--------
USB/examples/CustomHIDDevice00⚠️ +240--------
USB/examples/FirmwareMSC00⚠️ +240--------
USB/examples/Gamepad00⚠️ +240--------
USB/examples/HIDVendor00⚠️ +240--------
USB/examples/Keyboard/KeyboardLogout00⚠️ +240--------
USB/examples/Keyboard/KeyboardMessage00⚠️ +240--------
USB/examples/Keyboard/KeyboardReprogram00⚠️ +240--------
USB/examples/Keyboard/KeyboardSerial00⚠️ +240--------
USB/examples/KeyboardAndMouseControl00⚠️ +240--------
USB/examples/MIDI/MidiController00⚠️ +240--------
USB/examples/MIDI/MidiInterface00⚠️ +240--------
USB/examples/MIDI/MidiMusicBox00⚠️ +240--------
USB/examples/MIDI/ReceiveMidi00⚠️ +240--------
USB/examples/Mouse/ButtonMouseControl00⚠️ +240--------
USB/examples/SystemControl00⚠️ +240--------
USB/examples/USBMSC00⚠️ +240--------
USB/examples/USBSerial00⚠️ +240--------
USB/examples/USBVendor00⚠️ +240--------
Update/examples/AWS_S3_OTA_Update00⚠️ +2400000--⚠️ +240
Update/examples/HTTPS_OTA_Update00⚠️ +2400000--⚠️ +280
Update/examples/HTTP_Client_AES_OTA_Update00⚠️ +2400000--⚠️ +240
Update/examples/HTTP_Server_AES_OTA_Update00⚠️ +2800000--⚠️ +200
Update/examples/OTAWebUpdater00000000--⚠️ +280
Update/examples/SD_Update00⚠️ +240000000⚠️ +320
WebServer/examples/AdvancedWebServer00⚠️ +2400000--⚠️ +320
WebServer/examples/FSBrowser00⚠️ +1200000--⚠️ +280
WebServer/examples/Filters00⚠️ +2400000--⚠️ +280
WebServer/examples/HelloServer00⚠️ +2800000--⚠️ +320
WebServer/examples/HttpAdvancedAuth00⚠️ +1600000--⚠️ +280
WebServer/examples/HttpAuthCallback00⚠️ +2400000--⚠️ +280
WebServer/examples/HttpAuthCallbackInline00⚠️ +2400000--⚠️ +280
WebServer/examples/HttpBasicAuth00⚠️ +2400000--⚠️ +280
WebServer/examples/HttpBasicAuthSHA100⚠️ +2400000--⚠️ +280
WebServer/examples/HttpBasicAuthSHA1orBearerToken00⚠️ +2800000--⚠️ +280
WebServer/examples/MultiHomedServers00⚠️ +2400000--⚠️ +280
WebServer/examples/PathArgServer00⚠️ +2400000--⚠️ +280
WebServer/examples/SDWebServer00⚠️ +2400000--⚠️ +280
WebServer/examples/SimpleAuthentification00⚠️ +2400000--⚠️ +320
WebServer/examples/UploadHugeFile00⚠️ +3200000--⚠️ +280
WebServer/examples/WebServer00⚠️ +2400000--⚠️ +280
WebServer/examples/WebUpdate00⚠️ +2400000--⚠️ +280
WiFi/examples/FTM/FTM_Initiator00⚠️ +2400000--⚠️ +280
WiFi/examples/FTM/FTM_Responder00⚠️ +2800000--⚠️ +280
WiFi/examples/SimpleWiFiServer00⚠️ +2400000--⚠️ +280
WiFi/examples/WPS00000000--⚠️ +280
WiFi/examples/WiFiAccessPoint00⚠️ +2800000--⚠️ +280
WiFi/examples/WiFiBlueToothSwitch00--0000--⚠️ +280
WiFi/examples/WiFiClient00⚠️ +2400000--⚠️ +280
WiFi/examples/WiFiClientBasic00⚠️ +2400000--⚠️ +280
WiFi/examples/WiFiClientConnect00⚠️ +2400000--⚠️ +280
WiFi/examples/WiFiClientEnterprise00⚠️ +2400000--⚠️ +280
WiFi/examples/WiFiClientEvents00⚠️ +2400000--⚠️ +280
WiFi/examples/WiFiClientStaticIP00⚠️ +2400000--⚠️ +280
WiFi/examples/WiFiExtender00⚠️ +2400000--⚠️ +280
WiFi/examples/WiFiIPv600⚠️ +2400000--⚠️ +200
WiFi/examples/WiFiMulti00⚠️ +2400000--⚠️ +320
WiFi/examples/WiFiMultiAdvanced00⚠️ +2000000--⚠️ +320
WiFi/examples/WiFiScan00⚠️ +2400000--⚠️ +280
WiFi/examples/WiFiScanAsync00⚠️ +2800000--⚠️ +280
WiFi/examples/WiFiScanDualAntenna00⚠️ +2800000--⚠️ +280
WiFi/examples/WiFiScanTime00⚠️ +2400000--⚠️ +280
WiFi/examples/WiFiSmartConfig00⚠️ +2800000--⚠️ +400
WiFi/examples/WiFiTelnetToSerial00⚠️ +2400000--⚠️ +280
WiFi/examples/WiFiUDPClient00⚠️ +2400000--⚠️ +200
WiFiProv/examples/WiFiProv00⚠️ +2800000--⚠️ +320
Wire/examples/WireMaster00⚠️ +240000000⚠️ +320
Wire/examples/WireScan00⚠️ +240000000⚠️ +320
Wire/examples/WireSlave00⚠️ +240000000⚠️ +320
OpenThread/examples/COAP/coap_lamp------0000--
OpenThread/examples/COAP/coap_switch------0000--
OpenThread/examples/SimpleCLI------0000--
OpenThread/examples/SimpleNode------0000--
OpenThread/examples/SimpleThreadNetwork/ExtendedRouterNode------0000--
OpenThread/examples/SimpleThreadNetwork/LeaderNode------0000--
OpenThread/examples/SimpleThreadNetwork/RouterNode------0000--
OpenThread/examples/ThreadScan------0000--
OpenThread/examples/onReceive------0000--
BluetoothSerial/examples/DiscoverConnect----------⚠️ +280
BluetoothSerial/examples/GetLocalMAC----------⚠️ +240
BluetoothSerial/examples/SerialToSerialBT----------⚠️ +280
BluetoothSerial/examples/SerialToSerialBTM----------⚠️ +280
BluetoothSerial/examples/SerialToSerialBT_Legacy----------⚠️ +320
BluetoothSerial/examples/SerialToSerialBT_SSP----------⚠️ +280
BluetoothSerial/examples/bt_classic_device_discovery----------⚠️ +280
BluetoothSerial/examples/bt_remove_paired_devices----------⚠️ +280
ESP32/examples/DeepSleep/SmoothBlink_ULP_Code----------⚠️ +320
ESP32/examples/Touch/TouchButton----------⚠️ +320
Ethernet/examples/ETH_LAN8720----------⚠️ +320
Ethernet/examples/ETH_TLK110----------⚠️ +320

@me-no-dev me-no-dev merged commit 84ddf0a into master Oct 1, 2024
71 checks passed
@me-no-dev me-no-dev deleted the bugfix/psram_init_fail branch October 1, 2024 13:34
P-R-O-C-H-Y pushed a commit to P-R-O-C-H-Y/arduino-esp32 that referenced this pull request Oct 2, 2024
@me-no-dev @P-R-O-C-H-Y
fix(psram): Do not abort if PSRAM is not found (espressif#10395)
2746f5d 
Also add to heap in app_main
@enjoyneering enjoyneering mentioned this pull request Oct 25, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Status: Pending Merge Pull Request is ready to be merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@me-no-dev