Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(boards): Remove partition scheme overwrite from FlashSize menu #10400

Merged

Conversation

P-R-O-C-H-Y
Copy link
Member

Description of Change

This PR is removing partition overwrite from the FlashSize option as it's not even overwriting it.

Tests scenarios

Arduino IDE 2, Arduino IDE, Arduino-cli

Related links

Closes #10394

@P-R-O-C-H-Y P-R-O-C-H-Y self-assigned this Oct 2, 2024
Copy link
Contributor

github-actions bot commented Oct 2, 2024

Messages
📖 🎉 Good Job! All checks are passing!

👋 Hello P-R-O-C-H-Y, we appreciate your contribution to this project!


Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 224cd56

@P-R-O-C-H-Y P-R-O-C-H-Y requested a review from me-no-dev October 2, 2024 12:22
@me-no-dev me-no-dev added the Status: Pending Merge Pull Request is ready to be merged label Oct 4, 2024
@me-no-dev me-no-dev merged commit 5fd7826 into espressif:master Oct 4, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Pending Merge Pull Request is ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WROOM2 32MB Partition Discrepancies in boards.txt
2 participants