-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wire library: Add conditional compilation for second I2C interface based on SOC_I2C_NUM #10408
Conversation
…_NUM The ESP32, ESP32-S and ESP32-H series have two I2C interfaces, while the ESP32-C series has only one.
👋 Hello sivar2311, we appreciate your contribution to this project! Click to see more instructions ...
Review and merge process you can expect ...
|
Memory usage test (comparing PR against master branch)The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.
Click to expand the detailed deltas report [usage change in BYTES]
|
Test Results 41 files - 74 41 suites - 74 3m 12s ⏱️ - 31m 21s Results for commit 9aaea98. ± Comparison against base commit 733373a. This pull request removes 9 tests.
♻️ This comment has been updated with latest results. |
The ESP32, ESP32-S and ESP32-H series have two I2C interfaces, while the ESP32-C series has only one.
Description of Change
The
Wire1
object is conditionally compiled and is not available on MCUs that only have a single I2C interface (e.g. MCUs of the ESP32-C series).Tests scenarios
I tested my pull request on Arduino-esp32 core v3.1.0 with ESP32, ESP32-S3 and ESP32-C3 board with this scenario.
For the test I modified the WireScan example to use the
Wire1
object. On an ESP32-C3 based board the compilation failed which is the expected behaviour and intention of this PR.Related links
ESP32 Arduino Wire not working