Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(arduino): adds ESP32-P4 to the package description #10426

Merged
merged 2 commits into from
Oct 7, 2024

Conversation

SuGlider
Copy link
Collaborator

@SuGlider SuGlider commented Oct 6, 2024


Description of Change

Updates the Package description to add the P4 in 3.1.0

Tests scenarios

N/A

Related links

N/A

@SuGlider SuGlider added this to the 3.1.0 milestone Oct 6, 2024
@SuGlider SuGlider requested a review from me-no-dev October 6, 2024 15:51
@SuGlider SuGlider self-assigned this Oct 6, 2024
Copy link
Contributor

github-actions bot commented Oct 6, 2024

Warnings
⚠️
	The **target branch** for this Pull Request **must be the default branch** of the project (`master`).

	If you would like to add this feature to a different branch, please state this in the PR description and we will consider it.

👋 Hello SuGlider, we appreciate your contribution to this project!


Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 868089f

@VojtechBartoska VojtechBartoska added documentation 📝 Solely about the documentation of the project. Type: Documentation Issue pertains to Documentation of Arduino ESP32 and removed documentation 📝 Solely about the documentation of the project. labels Oct 7, 2024
@VojtechBartoska
Copy link
Contributor

VojtechBartoska commented Oct 7, 2024

Lets merge this after P4 initial support is merged.

  • we need to update also SoCs overview table in project documentation page

@lucasssvaz
Copy link
Collaborator

Lets merge this after P4 initial support is merged.

* we need to update also SoCs overview table in project documentation page

We can already merge. This is targeting the release v3.1.x branch and wont appear in the main page

@me-no-dev me-no-dev added the Status: Pending Merge Pull Request is ready to be merged label Oct 7, 2024
@VojtechBartoska
Copy link
Contributor

@lucasssvaz you are right

@SuGlider SuGlider requested a review from lucasssvaz October 7, 2024 13:03
Updates the Package description to add the P4 in 3.1.0
Adds ESP32-P$ to the list of supported SoC in README.md for Core 3.1.0
@lucasssvaz lucasssvaz force-pushed the update_pkg_description branch from 9a8afbf to 868089f Compare October 7, 2024 13:06
@me-no-dev me-no-dev merged commit ba9a3a1 into release/v3.1.x Oct 7, 2024
14 checks passed
@me-no-dev me-no-dev deleted the update_pkg_description branch October 7, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Pending Merge Pull Request is ready to be merged Type: Documentation Issue pertains to Documentation of Arduino ESP32
Projects
Development

Successfully merging this pull request may close these issues.

4 participants