Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(lib-builder): Improve UI and Docker image sections #10535

Merged
merged 2 commits into from
Oct 31, 2024

Conversation

lucasssvaz
Copy link
Collaborator

Description of Change

Improve Lib-Builder documentation by adding more info about the UI and the docker image

@lucasssvaz lucasssvaz added the Type: Documentation Issue pertains to Documentation of Arduino ESP32 label Oct 28, 2024
@lucasssvaz lucasssvaz self-assigned this Oct 28, 2024
Copy link
Contributor

github-actions bot commented Oct 28, 2024

Messages
📖 🎉 Good Job! All checks are passing!

👋 Hello lucasssvaz, we appreciate your contribution to this project!


Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 2cb84dc

@lucasssvaz lucasssvaz force-pushed the docs/lib_builder_improvements branch from c1a1d0f to 2af5885 Compare October 28, 2024 16:42
@pedrominatel pedrominatel added the Status: Review needed Issue or PR is awaiting review label Oct 28, 2024
Copy link
Member

@pedrominatel pedrominatel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @lucasssvaz!
Just some minor adjustments.

docs/en/lib_builder.rst Show resolved Hide resolved
docs/en/lib_builder.rst Outdated Show resolved Hide resolved
@lucasssvaz lucasssvaz added Status: Pending Merge Pull Request is ready to be merged and removed Status: Review needed Issue or PR is awaiting review labels Oct 30, 2024
@me-no-dev me-no-dev merged commit 05102fe into espressif:master Oct 31, 2024
12 checks passed
@lucasssvaz lucasssvaz deleted the docs/lib_builder_improvements branch November 1, 2024 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Pending Merge Pull Request is ready to be merged Type: Documentation Issue pertains to Documentation of Arduino ESP32
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants