Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(get.py): Check if win32 tools also exist when running on win64 #10565

Merged
merged 2 commits into from
Nov 4, 2024

Conversation

lucasssvaz
Copy link
Collaborator

@lucasssvaz lucasssvaz commented Nov 4, 2024

Description of Change

Check if win32 binaries also exist when compiling in win64. Also set the CWD of the script to the file location so it will always extract to the proper place

Tests scenarios

Locally

@lucasssvaz lucasssvaz added the Area: Tools & Build System Issue is related to tools and/or the build system label Nov 4, 2024
@lucasssvaz lucasssvaz self-assigned this Nov 4, 2024
Copy link
Contributor

github-actions bot commented Nov 4, 2024

Messages
📖 🎉 Good Job! All checks are passing!

👋 Hello lucasssvaz, we appreciate your contribution to this project!


Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 8fd4624

@lucasssvaz lucasssvaz requested a review from me-no-dev November 4, 2024 18:58
@lucasssvaz lucasssvaz marked this pull request as ready for review November 4, 2024 18:59
@lucasssvaz lucasssvaz added the Status: Review needed Issue or PR is awaiting review label Nov 4, 2024
@me-no-dev me-no-dev added Status: Pending Merge Pull Request is ready to be merged and removed Status: Review needed Issue or PR is awaiting review labels Nov 4, 2024
@me-no-dev me-no-dev merged commit 11f3cff into master Nov 4, 2024
47 of 49 checks passed
@me-no-dev me-no-dev deleted the bugfix/get_script branch November 4, 2024 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Tools & Build System Issue is related to tools and/or the build system Status: Pending Merge Pull Request is ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants