Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AsyncUdp license and keyword update #10637

Merged
merged 13 commits into from
Nov 25, 2024
Merged

AsyncUdp license and keyword update #10637

merged 13 commits into from
Nov 25, 2024

Conversation

SuGlider
Copy link
Collaborator

Description of Change

Adding license information to AsyncUDP library + updating all keywords used in the library.

Tests scenarios

CI Only

Related links

None

@SuGlider SuGlider added this to the 3.0.8 milestone Nov 22, 2024
@SuGlider SuGlider self-assigned this Nov 22, 2024
@SuGlider SuGlider added the Status: Review needed Issue or PR is awaiting review label Nov 22, 2024
Copy link
Contributor

github-actions bot commented Nov 22, 2024

Warnings
⚠️ Please consider squashing your 13 commits (simplifying branch history).

👋 Hello SuGlider, we appreciate your contribution to this project!


Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 449237a

Copy link
Contributor

github-actions bot commented Nov 22, 2024

Test Results

 56 files   56 suites   4m 17s ⏱️
 21 tests  21 ✅ 0 💤 0 ❌
134 runs  134 ✅ 0 💤 0 ❌

Results for commit 369427f.

♻️ This comment has been updated with latest results.

@me-no-dev
Copy link
Member

This is not software made by Espressif, but by me before I worked for Espressif. I will think of headers for it :)

@me-no-dev
Copy link
Member

@SuGlider can you please remove the licenses and leave just keywords.txt? I will merge that

@SuGlider
Copy link
Collaborator Author

@SuGlider can you please remove the licenses and leave just keywords.txt? I will merge that

Done.

@me-no-dev me-no-dev added Status: Pending Merge Pull Request is ready to be merged and removed Status: Review needed Issue or PR is awaiting review labels Nov 25, 2024
@me-no-dev me-no-dev merged commit 4fc8abf into master Nov 25, 2024
7 checks passed
@me-no-dev me-no-dev deleted the asyncudp_license branch November 25, 2024 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Pending Merge Pull Request is ready to be merged
Projects
Development

Successfully merging this pull request may close these issues.

3 participants