-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(matter): New Matter Fan endpoint #10687
Conversation
👋 Hello SuGlider, we appreciate your contribution to this project! Click to see more instructions ...
Review and merge process you can expect ...
|
Test Results 61 files 61 suites 5m 47s ⏱️ Results for commit 7b3fe09. ♻️ This comment has been updated with latest results. |
Memory usage test (comparing PR against master branch)The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.
Click to expand the detailed deltas report [usage change in BYTES]
|
fix(matter): reveting non related endpoint code change
protected: | ||
bool started = false; | ||
bool onOffState = false; // default initial state is off, but it can be changed by begin(bool) | ||
espHsvColor_t colorHSV = {0}; // default initial color HSV is black, but it can be changed by begin(bool, espHsvColor_t)``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
espHsvColor_t colorHSV = {0}; // default initial color HSV is black, but it can be changed by begin(bool, espHsvColor_t)``` | |
espHsvColor_t colorHSV = {0}; // default initial color HSV is black, but it can be changed by begin(bool, espHsvColor_t) | |
MatterColorLight(); | ||
~MatterColorLight(); | ||
// default initial state is off, color is red 12% intensity HSV(0, 254, 31) | ||
virtual bool begin(bool initialState = false, espHsvColor_t colorHSV = { 0, 254, 31}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
virtual bool begin(bool initialState = false, espHsvColor_t colorHSV = { 0, 254, 31}); | |
virtual bool begin(bool initialState = false, espHsvColor_t colorHSV = {0, 254, 31}); | |
Description of Change
Adds Fan as an endpoint. Matter Fan can control On/Off state and its velocity.
It also has a configurable set of Modes.
Tests scenarios
ESP32S3 using the provided example.
Related links
Related to #7432