Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(arduino): remove all while(not serial) in examples #10715

Merged

Conversation

SuGlider
Copy link
Collaborator

Description of Change

A problem with while(!Serial){} was detected when using USB CDC and DEBUG Level active.
This PR removes it from all examples.

Tests scenarios

CI Only

Related links

None.

@SuGlider SuGlider added the Type: Example Issue is related to specific example. label Dec 11, 2024
@SuGlider SuGlider added this to the 3.0.8 milestone Dec 11, 2024
@SuGlider SuGlider self-assigned this Dec 11, 2024
Copy link
Contributor

github-actions bot commented Dec 11, 2024

Messages
📖 🎉 Good Job! All checks are passing!

👋 Hello SuGlider, we appreciate your contribution to this project!


Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 029a57f

@SuGlider SuGlider added the Status: Review needed Issue or PR is awaiting review label Dec 11, 2024
@SuGlider SuGlider added Status: Pending Merge Pull Request is ready to be merged and removed Status: Review needed Issue or PR is awaiting review labels Dec 11, 2024
@me-no-dev me-no-dev merged commit fb6e977 into espressif:master Dec 11, 2024
41 of 43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Pending Merge Pull Request is ready to be merged Type: Example Issue is related to specific example.
Projects
Development

Successfully merging this pull request may close these issues.

3 participants